refactor(autoware_pointcloud_preprocessor): rework vector map inside area filter parameters #8493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <[email protected]>
vividf
added
run:deploy-docs
Signed-off-by: vividf <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8493 +/- ##
==========================================
- Coverage 23.96% 23.86% -0.10%
==========================================
Files 1382 1387 +5
Lines 102019 101726 -293
Branches 38886 38721 -165
==========================================
- Hits 24446 24281 -165
+ Misses 75141 74968 -173
- Partials 2432 2477 +45
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yukkysaito
approved these changes
Aug 19, 2024
amadeuszsz
requested changes
Aug 20, 2024
sensing/autoware_pointcloud_preprocessor/schema/vector_map_inside_area_filter_node.schema.json
Show resolved
Hide resolved
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…area filter parameters (autowarefoundation#8493) * feat: rework vector map inside area filter parameter Signed-off-by: vividf <[email protected]> * chore: fix launcher Signed-off-by: vividf <[email protected]> * chore: fix launcher input and output Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…area filter parameters (autowarefoundation#8493) * feat: rework vector map inside area filter parameter Signed-off-by: vividf <[email protected]> * chore: fix launcher Signed-off-by: vividf <[email protected]> * chore: fix launcher input and output Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
vividf
deleted the
refactor/rework_vector_map_inside_area_filter_parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor vector_map_inside_area_filter_node.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.