refactor(autoware_pointcloud_preprocessor): rework voxel grid outlier filter parameters #8476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vividf
changed the title
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
vividf
added
the
run:build-and-test-differential
badai-nguyen
added
the
run:deploy-docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8476 +/- ##
==========================================
- Coverage 24.06% 23.77% -0.29%
==========================================
Files 1384 1391 +7
Lines 102216 102002 -214
Branches 38963 38945 -18
==========================================
- Hits 24594 24255 -339
- Misses 75105 75272 +167
+ Partials 2517 2475 -42
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
optional: there is a parameter that should not be a signed integer |
knzo25
approved these changes
Aug 20, 2024
Signed-off-by: vividf <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
… filter parameters (autowarefoundation#8476) * feat: rework voxel grid outlier filter parameters Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
… filter parameters (autowarefoundation#8476) * feat: rework voxel grid outlier filter parameters Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
… filter parameters (autowarefoundation#8476) * feat: rework voxel grid outlier filter parameters Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
vividf
deleted the
refactor/rework_voxel_grid_outlier_filter_parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
nodelettonode.A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor voxel_grid_outlier_filter_node.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.