refactor(autoware_pointcloud_preprocessor): rework crop box parameters

[vividf]

Description

This PR includes the following changes

1. Remove the default parameters for the crop box filter node.
2. Add parameter, launch file, and parameters schema for the node.
3. Change the name nodelet to node.

A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.

Note that the schema for filter.param.yaml will be implemented in another PR.

Related links

Parent Issue:

• Link

How was this PR tested?

ros2 launch autoware_pointcloud_preprocessor crop_box_filter_node.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 23.87%. Comparing base (92868c0) to head (eb347bc).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
...essor/src/crop_box_filter/crop_box_filter_node.cpp	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8466      +/-   ##
==========================================
- Coverage   27.50%   23.87%   -3.64%     
==========================================
  Files        1303     1442     +139     
  Lines      101046   104080    +3034     
  Branches    39180    40075     +895     
==========================================
- Hits        27794    24847    -2947     
- Misses      70544    76674    +6130     
+ Partials     2708     2559     -149     

Flag	Coverage Δ		*Carryforward flag
differential	20.89% <0.00%> (?)
total	23.89% <ø> (-3.62%)	⬇️	Carriedforward from 9d10076

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knzo25]

Should filter.param.yaml be in this PR?

[vividf]

@knzo25 It is not needed in this PR, I put it here just because when the launch file launch without having the filter.param.yaml file, it will show a warning message. (but it will not cause any issue since the filter.cpp has the default parameter, and that's why I remove the filter.param.yaml in other PRs). I will also remove this one. Thanks!

[github-actions]

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8466/
Modified URLs:

• https://autowarefoundation.github.io/autoware.universe/pr-8466/sensing/autoware_pointcloud_preprocessor/crop-box-filter/

[vividf]

@knzo25 kindly ping

[vividf]

@badai-nguyen @knzo25 @drwnz

[badai-nguyen]

@vividf Please add missing parameter (negative: false) for this since crop_box_filter also used in euclidean_cluster pipeline.
I created PR for neccessary modification in autoware_launch and please wait until it is merged.

[knzo25]

Documentation related comments

[vividf]

@badai-nguyen thanks for the check, added in add0cb7

[knzo25]

LGTM

[vividf]

@badai-nguyen kindly ping

[badai-nguyen]

LGTM