refactor(lidar_apollo_segmentation_tvm): remove lidar_apollo_segmentation_tvm** packages
#7996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
ktro2828
force-pushed
the
refactor/lidar_apollo_segmentation_tvm/autoware-namespace
branch
from
af16b96 to
d32733b
Compare
ktro2828
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7996 +/- ##
==========================================
- Coverage 29.12% 29.01% -0.12%
==========================================
Files 1609 1620 +11
Lines 118111 118599 +488
Branches 50843 51034 +191
==========================================
+ Hits 34402 34409 +7
- Misses 74494 74977 +483
+ Partials 9215 9213 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@YoshiRi @kminoda Given https://github.com/orgs/autowarefoundation/discussions/4883#discussioncomment-9876908 do we want to spend effort refactoring this package? Is there an update on whether |
|
@ambroise-arm Thank you for bringing that up. I forgot that. @ktro2828 Let's remove this package. Sorry for bringing this up after you made an effort to create this PR 🙏 🙇 |
ktro2828
force-pushed
the
refactor/lidar_apollo_segmentation_tvm/autoware-namespace
branch
from
88e2d4e to
fab75db
Compare
ktro2828
changed the title
lidar_apollo_segmentation_tvm** packages
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
ktro2828
force-pushed
the
refactor/lidar_apollo_segmentation_tvm/autoware-namespace
branch
from
fab75db to
663b7a5
Compare
|
@ambroise-arm @YoshiRi @kminoda I've removed |
This was referenced Jul 24, 2024
kminoda
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
LGTM
@ktro2828 Would you add this to the description?
autowarefoundation/autoware#5022
ambroise-arm
approved these changes
Jul 24, 2024
|
Relates to #7701 |
3 tasks
ktro2828
deleted the
refactor/lidar_apollo_segmentation_tvm/autoware-namespace
branch
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 26, 2024
…ation_tvm**` packages (autowarefoundation#7996) * refactor: add autoware prefix to lidar_apollo_segmentation_tvm Signed-off-by: ktro2828 <[email protected]> * refactor: add autoware prefix to lidar_apollo_segmentation_tvm_nodes Signed-off-by: ktro2828 <[email protected]> * chore: update CODEOWNERS Signed-off-by: ktro2828 <[email protected]> * chore: remove `lidar_apollo_segmentation_tvm**` package Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…ation_tvm**` packages (autowarefoundation#7996) * refactor: add autoware prefix to lidar_apollo_segmentation_tvm Signed-off-by: ktro2828 <[email protected]> * refactor: add autoware prefix to lidar_apollo_segmentation_tvm_nodes Signed-off-by: ktro2828 <[email protected]> * chore: update CODEOWNERS Signed-off-by: ktro2828 <[email protected]> * chore: remove `lidar_apollo_segmentation_tvm**` package Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
lidar_apollo_segmentation_tvmandlidar_apollo_segmentation_tvm_nodes.This PR puts headers in theautowarenamespace.Additional works1. Align directory structure to follow the coding guidelines.2. Clean unused dependencies LISTRelated links
Parent Issue:
- Part of: autowarefoundation/autoware#4569How was this PR tested?
I tested bothlidar_apollo_segmentation_tvm_nodes.launch.xmlandlidar_apollo_segmentation_tvm_nodes.launch.py.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.