fix(tier4_planning_rviz_plugin): fix calculation of drivable area bounds #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: beyza <[email protected]>
beyzanurkaya
added
component:planning
github-actions
bot
added
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7815 +/- ##
==========================================
- Coverage 28.55% 28.55% -0.01%
==========================================
Files 1586 1587 +1
Lines 115879 115904 +25
Branches 49384 49387 +3
==========================================
Hits 33093 33093
- Misses 73823 73848 +25
Partials 8963 8963
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Jul 3, 2024
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…nds (autowarefoundation#7815) change angle condition Signed-off-by: beyza <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…nds (autowarefoundation#7815) change angle condition Signed-off-by: beyza <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…nds (#7815) change angle condition Signed-off-by: beyza <[email protected]>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…nds (autowarefoundation#7815) change angle condition Signed-off-by: beyza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #7684
Actually, cases where
diff_angleis 0 are handled differently here, but when values very close to 0 are handled as any other value, the width is miscalculated, so strange boundaries appear.Related links
Parent Issue:
How was this PR tested?
inaccurate-drivable-area.mp4
drivable-area.mp4
Notes for reviewers
Before testing the PR you should enable the
dynamic_obstacle_avoidance_moduleindefault_preset.yamlInterface changes
None.
Effects on system behavior
None.