refactor(localization_util): add covariance_ellipse to localization_util #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
added
run:build-and-test-differential
github-actions
bot
added
the
component:localization
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7706 +/- ##
===========================================
+ Coverage 14.84% 29.45% +14.61%
===========================================
Files 1999 64 -1935
Lines 139163 3537 -135626
Branches 43716 1090 -42626
===========================================
- Hits 20661 1042 -19619
+ Misses 95731 2382 -93349
+ Partials 22771 113 -22658
☔ View full report in Codecov by Sentry. |
SakodaShintaro
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
TaikiYamada4,
YamatoAndo and
kminoda
as code owners
YamatoAndo
approved these changes
Jun 26, 2024
SakodaShintaro
merged commit 10c1a85
into
autowarefoundation:main
54 of 55 checks passed
SakodaShintaro
deleted the
refactor/add_covariance_ellipse_to_localization_util
branch
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…til (autowarefoundation#7706) Added covariance_ellipse to localization_util Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…til (autowarefoundation#7706) Added covariance_ellipse to localization_util Signed-off-by: Shintaro Sakoda <[email protected]>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…til (autowarefoundation#7706) Added covariance_ellipse to localization_util Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…til (autowarefoundation#7706) Added covariance_ellipse to localization_util Signed-off-by: Shintaro Sakoda <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…til (#7706) Added covariance_ellipse to localization_util Signed-off-by: Shintaro Sakoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since several modules, not only ekf, output pose_with_covariance, it would be a good idea to move the error ellipse struct and its visualization code into localization_util to make it common.
Related links
None.
How was this PR tested?
I have confirmed that logging_simulator works well.
To get a larger error ellipse, I ran the experiment with NDT turned off and confirmed that the correct error ellipse was visualized just as before.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.