Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix failure condition when modified files are empty #7704

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jun 26, 2024

Description

Fix failure condition when modified files are empty in cppcheck-differential.

Related links

A test due to empty modified files. (the PR deletes all the package files)
https://github.com/autowarefoundation/autoware.universe/actions/runs/9673888348/job/26688603324

How was this PR tested?

The workflow works well with diffs that includes deleted files only.
https://github.com/HansRobo/autoware.universe/actions/runs/9675016733/job/26691735752

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Kotaro Yoshimoto <[email protected]>
@veqcc
Copy link
Contributor

veqcc commented Jun 26, 2024

@HansRobo
Is there any difference between modified and changed ?

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jun 26, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
@HansRobo
Copy link
Member Author

@veqcc

Is there any difference between modified and changed ?

No.
The spelling variations between changed and modified have been unified to changed in 6a89898.

@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jun 26, 2024
@HansRobo HansRobo requested a review from veqcc June 26, 2024 07:09
@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 26, 2024
@HansRobo HansRobo marked this pull request as ready for review June 26, 2024 07:10
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Copy link
Contributor

@veqcc veqcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your quick work!! LGTM 👍

@veqcc
Copy link
Contributor

veqcc commented Jun 26, 2024

@HansRobo
Please confirm DCO!!

@HansRobo
Copy link
Member Author

@veqcc I set DCO to pass manually.

@veqcc veqcc merged commit b261aec into autowarefoundation:main Jun 26, 2024
25 checks passed
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…arefoundation#7704)

* chore(ci): fix failure condition when modified files are empty

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete unnecessary new line

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete lidar_centerpoint_tvm package for test

Signed-off-by: GitHub <[email protected]>

* chore(ci): fix workflow conditions
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): filter un-existing files in cppcheck-differential
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* Revert "chore: delete lidar_centerpoint_tvm package for test"

This reverts commit 3b8bcb3.

* chore: fix pre-commit errors
Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…arefoundation#7704)

* chore(ci): fix failure condition when modified files are empty

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete unnecessary new line

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete lidar_centerpoint_tvm package for test

Signed-off-by: GitHub <[email protected]>

* chore(ci): fix workflow conditions
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): filter un-existing files in cppcheck-differential
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* Revert "chore: delete lidar_centerpoint_tvm package for test"

This reverts commit 3b8bcb3.

* chore: fix pre-commit errors
Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: GitHub <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…arefoundation#7704)

* chore(ci): fix failure condition when modified files are empty

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete unnecessary new line

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete lidar_centerpoint_tvm package for test

Signed-off-by: GitHub <[email protected]>

* chore(ci): fix workflow conditions
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): filter un-existing files in cppcheck-differential
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* Revert "chore: delete lidar_centerpoint_tvm package for test"

This reverts commit 3b8bcb3.

* chore: fix pre-commit errors
Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…arefoundation#7704)

* chore(ci): fix failure condition when modified files are empty

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete unnecessary new line

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete lidar_centerpoint_tvm package for test

Signed-off-by: GitHub <[email protected]>

* chore(ci): fix workflow conditions
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): filter un-existing files in cppcheck-differential
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* Revert "chore: delete lidar_centerpoint_tvm package for test"

This reverts commit 3b8bcb3.

* chore: fix pre-commit errors
Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: GitHub <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* chore(ci): fix failure condition when modified files are empty

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete unnecessary new line

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore: delete lidar_centerpoint_tvm package for test

Signed-off-by: GitHub <[email protected]>

* chore(ci): fix workflow conditions
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): filter un-existing files in cppcheck-differential
Signed-off-by: Kotaro Yoshimoto <[email protected]>

* Revert "chore: delete lidar_centerpoint_tvm package for test"

This reverts commit 3b8bcb3.

* chore: fix pre-commit errors
Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: GitHub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants