Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(out_of_lane): downsample the trajectory to improve performance #7691

Merged
merged 2 commits into from
Jun 26, 2024
Merged

perf(out_of_lane): downsample the trajectory to improve performance #7691

merged 2 commits into from
Jun 26, 2024

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jun 25, 2024 •
edited
Loading

Description

Quick fix to improve the performance of the out_of_lane module.
A better solution should be implemented in the future.

Private Links:

How was this PR tested?

Psim

Notes for reviewers

None.

Interface changes

None.

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.19%. Comparing base (507e3f4) to head (840029d).
Report is 140 commits behind head on main.

Files Patch % Lines
...locity_planner_common/trajectory_preprocessing.hpp 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #7691       +/-   ##
===========================================
- Coverage   14.84%   11.19%    -3.65%     
===========================================
  Files        1999      196     -1803     
  Lines      139163    17019   -122144     
  Branches    43716     3072    -40644     
===========================================
- Hits        20661     1906    -18755     
+ Misses      95731    14752    -80979     
+ Partials    22771      361    -22410
Flag Coverage Δ
differential 11.19% <87.50%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem enabled auto-merge (squash) June 26, 2024 05:39
@maxime-clem maxime-clem merged commit 8444a9e into autowarefoundation:main Jun 26, 2024
29 of 31 checks passed
@maxime-clem maxime-clem deleted the perf/out_of_lane branch June 26, 2024 05:42
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2024
@maxime-clem
perf(out_of_lane): downsample the trajectory to improve performance (a…
637be55 
…utowarefoundation#7691)

Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem mentioned this pull request Jun 26, 2024
Closed
4 tasks
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
@maxime-clem @simon-eisenmann-driveblocks
perf(out_of_lane): downsample the trajectory to improve performance (a…
196b7ac 
…utowarefoundation#7691)

Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Jun 27, 2024
@maxime-clem
Revert "perf(out_of_lane): downsample the trajectory to improve perfo…
a2d9311 
…rmance (autowarefoundation#7691)"

This reverts commit 8444a9e.
@maxime-clem maxime-clem mentioned this pull request Jul 1, 2024
Merged
takayuki5168 pushed a commit that referenced this pull request Jul 1, 2024
@maxime-clem
perf(motion_velocity_planner): resample trajectory after vel smoothing (
632d206 
#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Jul 1, 2024
@maxime-clem
perf(motion_velocity_planner): resample trajectory after vel smoothing (
3eb577e 
autowarefoundation#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (autowarefoundation#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Jul 1, 2024
@maxime-clem
perf(motion_velocity_planner): resample trajectory after vel smoothing (
91da574 
autowarefoundation#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (autowarefoundation#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
@maxime-clem @mitukou1109
perf(out_of_lane): downsample the trajectory to improve performance (a…
2a61cdf 
…utowarefoundation#7691)

Signed-off-by: Maxime CLEMENT <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
@maxime-clem @mitukou1109
perf(motion_velocity_planner): resample trajectory after vel smoothing (
a2c2263 
autowarefoundation#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (autowarefoundation#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@maxime-clem @palas21
perf(out_of_lane): downsample the trajectory to improve performance (a…
bb2f43d 
…utowarefoundation#7691)

Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: palas21 <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@maxime-clem @palas21
perf(motion_velocity_planner): resample trajectory after vel smoothing (
14bbefe 
autowarefoundation#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (autowarefoundation#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@maxime-clem @tby-udel
perf(out_of_lane): downsample the trajectory to improve performance (a…
c111684 
…utowarefoundation#7691)

Signed-off-by: Maxime CLEMENT <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@maxime-clem @tby-udel
perf(motion_velocity_planner): resample trajectory after vel smoothing (
e900420 
autowarefoundation#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (autowarefoundation#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@maxime-clem @KhalilSelyan
perf(out_of_lane): downsample the trajectory to improve performance (#…
6482681 
…7691)

Signed-off-by: Maxime CLEMENT <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@maxime-clem @KhalilSelyan
perf(motion_velocity_planner): resample trajectory after vel smoothing (
2ab2c2a 
#7732)

* perf(dynamic_obstacle_stop): create rtree with packing algorithm

Signed-off-by: Maxime CLEMENT <[email protected]>

* Revert "perf(out_of_lane): downsample the trajectory to improve performance (#7691)"

This reverts commit 8444a9e.

* perf(motion_velocity_planner): resample trajectory after vel smoothing

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara left review comments

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime-clem @takayuki5168 @kyoichi-sugahara