Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner, behavior_velocity_planner): fix redefinition errors #7688

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 25, 2024

Description

These are the fixes based on clang-tidy CRITICAL errors.
Screenshot 2024-06-25 at 17 52 54

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 25, 2024
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.61%. Comparing base (3d849e9) to head (69f919b).
Report is 545 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7688      +/-   ##
==========================================
- Coverage   15.09%   11.61%   -3.48%     
==========================================
  Files        1967      469    -1498     
  Lines      135941    42514   -93427     
  Branches    42122     6843   -35279     
==========================================
- Hits        20520     4939   -15581     
+ Misses      92700    37012   -55688     
+ Partials    22721      563   -22158     
Flag Coverage Δ
differential 11.61% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@veqcc veqcc merged commit 445bc34 into autowarefoundation:main Jul 1, 2024
28 of 30 checks passed
@veqcc veqcc deleted the fix_redefinition_error branch July 1, 2024 05:03
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants