-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): fix error in clang-tidy-differential
with diffs in multiple files
#7685
Merged
HansRobo
merged 6 commits into
autowarefoundation:main
from
HansRobo:fix-clang-tidy-diff-modified-files
Jun 25, 2024
Merged
chore(ci): fix error in clang-tidy-differential
with diffs in multiple files
#7685
HansRobo
merged 6 commits into
autowarefoundation:main
from
HansRobo:fix-clang-tidy-diff-modified-files
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <[email protected]>
github-actions
bot
added
the
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
label
Jun 25, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Kotaro Yoshimoto <[email protected]>
github-actions
bot
added
the
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
label
Jun 25, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
HansRobo
commented
Jun 25, 2024
control/predicted_path_checker/include/predicted_path_checker/predicted_path_checker_node.hpp
Outdated
Show resolved
Hide resolved
HansRobo
commented
Jun 25, 2024
control/predicted_path_checker/include/predicted_path_checker/debug_marker.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
github-actions
bot
removed
the
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
label
Jun 25, 2024
HansRobo
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 25, 2024
veqcc
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…ple files (autowarefoundation#7685) * chore(ci): output modified file list without newlines Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> --------- Signed-off-by: Kotaro Yoshimoto <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…ple files (autowarefoundation#7685) * chore(ci): output modified file list without newlines Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> --------- Signed-off-by: Kotaro Yoshimoto <[email protected]>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…ple files (autowarefoundation#7685) * chore(ci): output modified file list without newlines Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> --------- Signed-off-by: Kotaro Yoshimoto <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…ple files (autowarefoundation#7685) * chore(ci): output modified file list without newlines Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> --------- Signed-off-by: Kotaro Yoshimoto <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ple files (#7685) * chore(ci): output modified file list without newlines Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): test diffs Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> * chore(ci): revert test diff Signed-off-by: Kotaro Yoshimoto <[email protected]> --------- Signed-off-by: Kotaro Yoshimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In latest main branch,
clang-tidy-differential
failed if a PR has diffs in multiple files.This PR fixes it.
Related links
None.
How was this PR tested?
I made test diffs in 2 files and checked that the clang-tidy received the modified files correctly.
https://github.com/autowarefoundation/autoware.universe/actions/runs/9660413607/job/26645958534
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.