Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix error in clang-tidy-differential with diffs in multiple files #7685

Merged

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jun 25, 2024

Description

In latest main branch, clang-tidy-differential failed if a PR has diffs in multiple files.
This PR fixes it.

Related links

None.

How was this PR tested?

I made test diffs in 2 files and checked that the clang-tidy received the modified files correctly.
https://github.com/autowarefoundation/autoware.universe/actions/runs/9660413607/job/26645958534

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 25, 2024
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Kotaro Yoshimoto <[email protected]>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jun 25, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
HansRobo added 2 commits June 25, 2024 19:58
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
@github-actions github-actions bot removed the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jun 25, 2024
@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024
@HansRobo HansRobo requested a review from veqcc June 25, 2024 11:01
@HansRobo HansRobo marked this pull request as ready for review June 25, 2024 11:02
@HansRobo HansRobo enabled auto-merge (squash) June 25, 2024 11:14
Copy link
Contributor

@veqcc veqcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HansRobo HansRobo merged commit 1d1ee46 into autowarefoundation:main Jun 25, 2024
25 checks passed
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…ple files (autowarefoundation#7685)

* chore(ci): output modified file list without newlines

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…ple files (autowarefoundation#7685)

* chore(ci): output modified file list without newlines

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…ple files (autowarefoundation#7685)

* chore(ci): output modified file list without newlines

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…ple files (autowarefoundation#7685)

* chore(ci): output modified file list without newlines

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ple files (#7685)

* chore(ci): output modified file list without newlines

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): test diffs

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

* chore(ci): revert test diff

Signed-off-by: Kotaro Yoshimoto <[email protected]>

---------

Signed-off-by: Kotaro Yoshimoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants