Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: revert PR #6989 #7676

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jun 25, 2024

Description

This reverts commit fffb149.

Related links

None

How was this PR tested?

None

Notes for reviewers

None

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 25, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 2.65%. Comparing base (507e3f4) to head (582a7ea).
Report is 134 commits behind head on main.

Files Patch % Lines
...dar_centerpoint/lib/preprocess/voxel_generator.cpp 0.00% 13 Missing ⚠️
...on/lidar_centerpoint/test/test_voxel_generator.cpp 0.00% 8 Missing ⚠️
...rpoint/lib/preprocess/pointcloud_densification.cpp 0.00% 4 Missing ⚠️
...rception/lidar_centerpoint/lib/centerpoint_trt.cpp 0.00% 3 Missing ⚠️
...ed_fusion/pointpainting_fusion/voxel_generator.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7676       +/-   ##
==========================================
- Coverage   14.84%   2.65%   -12.19%     
==========================================
  Files        1999     164     -1835     
  Lines      139163   10046   -129117     
  Branches    43716    1575    -42141     
==========================================
- Hits        20661     267    -20394     
+ Misses      95731    9723    -86008     
+ Partials    22771      56    -22715     
Flag Coverage Δ
differential 2.65% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25
Copy link
Contributor

knzo25 commented Jun 25, 2024

Instead of reverting this, would it not be less painful at this time to comment out the cuda tests from the cmake?

@kminoda kminoda closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants