fix(autoware_pid_longitudinal_controller, autoware_trajectory_follower_node): unite diagnostic_updater_ in PID and MPC. #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
HansOersted
requested review from
TakaHoribe,
takayuki5168 and
soblin
as code owners
github-actions
bot
added
the
component:control
HansOersted
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7674 +/- ##
===========================================
+ Coverage 14.84% 18.15% +3.30%
===========================================
Files 1999 151 -1848
Lines 139163 13471 -125692
Branches 43716 2001 -41715
===========================================
- Hits 20661 2445 -18216
+ Misses 95731 10652 -85079
+ Partials 22771 374 -22397
☔ View full report in Codecov by Sentry. |
HansOersted
changed the title
HansOersted
changed the title
HansOersted
changed the title
takayuki5168
approved these changes
Jun 25, 2024
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…r_node): unite diagnostic_updater_ in PID and MPC. (autowarefoundation#7674) * diag_updater_ added in PID Signed-off-by: Zhe Shen <[email protected]> * correct the pointer form Signed-off-by: Zhe Shen <[email protected]> * pre-commit Signed-off-by: Zhe Shen <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…r_node): unite diagnostic_updater_ in PID and MPC. (autowarefoundation#7674) * diag_updater_ added in PID Signed-off-by: Zhe Shen <[email protected]> * correct the pointer form Signed-off-by: Zhe Shen <[email protected]> * pre-commit Signed-off-by: Zhe Shen <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…r_node): unite diagnostic_updater_ in PID and MPC. (autowarefoundation#7674) * diag_updater_ added in PID Signed-off-by: Zhe Shen <[email protected]> * correct the pointer form Signed-off-by: Zhe Shen <[email protected]> * pre-commit Signed-off-by: Zhe Shen <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…r_node): unite diagnostic_updater_ in PID and MPC. (autowarefoundation#7674) * diag_updater_ added in PID Signed-off-by: Zhe Shen <[email protected]> * correct the pointer form Signed-off-by: Zhe Shen <[email protected]> * pre-commit Signed-off-by: Zhe Shen <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…r_node): unite diagnostic_updater_ in PID and MPC. (#7674) * diag_updater_ added in PID Signed-off-by: Zhe Shen <[email protected]> * correct the pointer form Signed-off-by: Zhe Shen <[email protected]> * pre-commit Signed-off-by: Zhe Shen <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR units diagnostic_updater_ in PID and MPC.
Tests performed
Local test by manually setting
m_control_state = ControlState::EMERGENCY;Screencast from 06-25-2024 11:48:17 AM.webm
Scenario test
https://evaluation.tier4.jp/evaluation/reports/a1a6f1d7-0cbb-56f4-bf11-3fb2cbea910d?project_id=prd_jt
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.