Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic_graph_aggregator): fix shadowArg warning in create_unit_config #7664

Merged

Conversation

Koichi98
Copy link
Contributor

Description

src/universe/autoware.universe/system/diagnostic_graph_aggregator/src/common/graph/config.cpp:105:21: style: Local variable 'data' shadows outer argument [shadowArgument]
  for (const auto & data : list) {
                    ^
src/universe/autoware.universe/system/diagnostic_graph_aggregator/src/common/graph/config.cpp:94:62: note: Shadowed declaration
UnitConfig * FileLoader::create_unit_config(const TreeData & data)
                                                             ^
src/universe/autoware.universe/system/diagnostic_graph_aggregator/src/common/graph/config.cpp:105:21: note: Shadow variable
  for (const auto & data : list) {

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Koichi98 Koichi98 requested a review from isamu-takagi as a code owner June 24, 2024 10:31
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 24, 2024
@Koichi98 Koichi98 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.67%. Comparing base (507e3f4) to head (0bdd825).
Report is 123 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7664       +/-   ##
===========================================
+ Coverage   14.84%   64.67%   +49.83%     
===========================================
  Files        1999       18     -1981     
  Lines      139163      620   -138543     
  Branches    43716      285    -43431     
===========================================
- Hits        20661      401    -20260     
+ Misses      95731      156    -95575     
+ Partials    22771       63    -22708     
Flag Coverage Δ
differential 64.67% <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koichi98 Koichi98 merged commit 435f368 into autowarefoundation:main Jun 25, 2024
40 checks passed
@Koichi98 Koichi98 deleted the fix_shadowArg_create_unit_config branch June 25, 2024 00:16
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants