Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_simulator): change nodes arg log level #7661

Conversation

gitoabdelgawad
Copy link

@gitoabdelgawad gitoabdelgawad commented Jun 24, 2024

Description

This draft PR modifies the --log-level argument for nodes, containers, and components launched from planning_simulator.

Often, it is necessary to adjust the log level to DEBUG for more detailed logging or reduce it to WARN or ERROR to minimize output. According to the ROS2 and Autoware documentation, there is currently no method to configure the logger via a configuration file or environment variable. The only way to change a node's logger at runtime is by using services.

This draft PR aims to initiate a discussion to explore if there are better solutions for adjusting the logging level. If no alternative solutions are identified, are such changes suitable for merging.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jun 24, 2024
@gitoabdelgawad gitoabdelgawad changed the title Feat/change nodes arg log level feat(planning_simulator): change nodes arg log level Jun 24, 2024
@mitsudome-r
Copy link
Member

This draft PR aims to initiate a discussion to explore if there are better solutions for adjusting the logging level. If no alternative solutions are identified, are such changes suitable for merging.

Is it okay to raise this in the GitHub Discussion first instead of PR?
You can create the thread under ideas or feature requests category.

https://github.com/orgs/autowarefoundation/discussions

@yukkysaito
Copy link
Contributor

@gitoabdelgawad Sorry for the late reply.

Being able to dynamically adjust the log level is indeed very useful, especially when debugging or minimizing log output.

However, I believe that specifying each log level in the launch files can be challenging from a maintenance perspective. I would like to hear everyone's opinions on whether there are more effective methods available.

@xmfcx @mitsudome-r Do you have any opinions?

@gitoabdelgawad
Copy link
Author

gitoabdelgawad commented Jul 8, 2024

Thank you @yukkysaito @mitsudome-r for your reply.
I opened a new discussion https://github.com/orgs/autowarefoundation/discussions/4952.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants