-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planning_simulator): change nodes arg log level #7661
feat(planning_simulator): change nodes arg log level #7661
Conversation
Signed-off-by: Osama Abdelgawad <[email protected]>
Signed-off-by: Osama Abdelgawad <[email protected]>
Signed-off-by: Osama Abdelgawad <[email protected]>
Is it okay to raise this in the GitHub Discussion first instead of PR? |
@gitoabdelgawad Sorry for the late reply. Being able to dynamically adjust the log level is indeed very useful, especially when debugging or minimizing log output. However, I believe that specifying each log level in the launch files can be challenging from a maintenance perspective. I would like to hear everyone's opinions on whether there are more effective methods available. @xmfcx @mitsudome-r Do you have any opinions? |
Thank you @yukkysaito @mitsudome-r for your reply. |
Description
This draft PR modifies the --log-level argument for nodes, containers, and components launched from planning_simulator.
Often, it is necessary to adjust the log level to DEBUG for more detailed logging or reduce it to WARN or ERROR to minimize output. According to the ROS2 and Autoware documentation, there is currently no method to configure the logger via a configuration file or environment variable. The only way to change a node's logger at runtime is by using services.
This draft PR aims to initiate a discussion to explore if there are better solutions for adjusting the logging level. If no alternative solutions are identified, are such changes suitable for merging.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.