Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/change nodes log level #7660

pass log level to aggregator

50a33cc
Select commit
Loading
Failed to load commit list.
Closed

Feat/change nodes log level #7660

pass log level to aggregator
50a33cc
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 24, 2024 in 42s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method control.launch.py: launch_setup
  • Large Method laserscan_based_occupancy_grid_map.launch.py: launch_setup

Annotations

Check warning on line 462 in launch/tier4_control_launch/launch/control.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

launch_setup increases from 380 to 394 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 127 in perception/probabilistic_occupancy_grid_map/launch/laserscan_based_occupancy_grid_map.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

launch_setup increases from 94 to 97 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.