Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_obstacle_cruise_planner): fix shadowVariable warning in generateSlowDownTrajectory #7659

Conversation

Koichi98
Copy link
Contributor

Description

This is a fix based on cppcheck warning.

src/universe/autoware.universe/planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp:626:17: style: Local variable 'i' shadows outer variable [shadowVariable]
    for (size_t i = (slow_down_start_idx ? *slow_down_start_idx : 0); i <= *slow_down_end_idx;
                ^
src/universe/autoware.universe/planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp:579:15: note: Shadowed declaration
  for (size_t i = 0; i < obstacles.size(); ++i) {
              ^
src/universe/autoware.universe/planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp:626:17: note: Shadow variable
    for (size_t i = (slow_down_start_idx ? *slow_down_start_idx : 0); i <= *slow_down_end_idx;

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

  • I've confirmed the [contribution guidelines].
  • The PR follows the [pull request guidelines].

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the [pull request guidelines].

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…generateSlowDownTrajectory

Signed-off-by: Koichi Imai <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 24, 2024
@Koichi98 Koichi98 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.52%. Comparing base (507e3f4) to head (e7b5f39).
Report is 122 commits behind head on main.

Files Patch % Lines
..._obstacle_cruise_planner/src/planner_interface.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7659       +/-   ##
==========================================
- Coverage   14.84%   6.52%    -8.33%     
==========================================
  Files        1999     138     -1861     
  Lines      139163   14530   -124633     
  Branches    43716    2538    -41178     
==========================================
- Hits        20661     948    -19713     
+ Misses      95731   13473    -82258     
+ Partials    22771     109    -22662     
Flag Coverage Δ
differential 6.52% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koichi98 Koichi98 merged commit 2a3eaee into autowarefoundation:main Jun 24, 2024
38 of 40 checks passed
@Koichi98 Koichi98 deleted the fix_shadowVariable_generateSlowDownTrajectory branch June 24, 2024 09:37
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…generateSlowDownTrajectory (autowarefoundation#7659)

Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants