-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_obstacle_cruise_planner): fix shadowVariable warning #7656
Merged
Koichi98
merged 3 commits into
autowarefoundation:main
from
Koichi98:fix_shadowVariable
Jun 24, 2024
Merged
fix(autoware_obstacle_cruise_planner): fix shadowVariable warning #7656
Koichi98
merged 3 commits into
autowarefoundation:main
from
Koichi98:fix_shadowVariable
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Koichi98
requested review from
kosuke55,
satoshi-ota,
takayuki5168 and
yuki-takagi-66
as code owners
June 24, 2024 08:16
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jun 24, 2024
Koichi98
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 24, 2024
kosuke55
approved these changes
Jun 24, 2024
takayuki5168
approved these changes
Jun 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7656 +/- ##
==========================================
- Coverage 14.84% 6.52% -8.33%
==========================================
Files 1999 138 -1861
Lines 139163 14531 -124632
Branches 43716 2541 -41175
==========================================
- Hits 20661 948 -19713
+ Misses 95731 13474 -82257
+ Partials 22771 109 -22662
☔ View full report in Codecov by Sentry. |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…towarefoundation#7656) * fix(autoware_obstacle_cruise_planner): fix shadowVariable warning Signed-off-by: Koichi Imai <[email protected]> * fix Signed-off-by: Koichi Imai <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Koichi Imai <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Simon Eisenmann <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…towarefoundation#7656) * fix(autoware_obstacle_cruise_planner): fix shadowVariable warning Signed-off-by: Koichi Imai <[email protected]> * fix Signed-off-by: Koichi Imai <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Koichi Imai <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
) * fix(autoware_obstacle_cruise_planner): fix shadowVariable warning Signed-off-by: Koichi Imai <[email protected]> * fix Signed-off-by: Koichi Imai <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Koichi Imai <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix based on cppcheck warning.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.