-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(radar_crossing_objects_noise_filter)!: fix namespace and directory structure #7649
refactor(radar_crossing_objects_noise_filter)!: fix namespace and directory structure #7649
Conversation
Signed-off-by: Taekjin LEE <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7649 +/- ##
==========================================
- Coverage 14.84% 4.30% -10.55%
==========================================
Files 1999 33 -1966
Lines 139163 1835 -137328
Branches 43716 125 -43591
==========================================
- Hits 20661 79 -20582
+ Misses 95731 1738 -93993
+ Partials 22771 18 -22753
☔ View full report in Codecov by Sentry. |
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Taekjin LEE <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)
…ectory structure (autowarefoundation#7649) * feat: Refactor radar_crossing_objects_noise_filter node Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: move header file to src Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
…ectory structure (autowarefoundation#7649) * feat: Refactor radar_crossing_objects_noise_filter node Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: move header file to src Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: palas21 <[email protected]>
…ectory structure (autowarefoundation#7649) * feat: Refactor radar_crossing_objects_noise_filter node Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: move header file to src Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
…ectory structure (#7649) * feat: Refactor radar_crossing_objects_noise_filter node Signed-off-by: Taekjin LEE <[email protected]> * refactor: fix the node name Signed-off-by: Taekjin LEE <[email protected]> * refactor: move header file to src Signed-off-by: Taekjin LEE <[email protected]> * refactor: remove unused dependency Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
Description
This PR puts headers in the
autoware
namespace.Part of: autowarefoundation/autoware#4569
Additional works
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.