Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ndt_scan_matcher): warn if the lidar scan has gone out of the range of the loaded map #7612
feat(ndt_scan_matcher): warn if the lidar scan has gone out of the range of the loaded map #7612
Changes from 8 commits
735a1a4
334f8ed
b1f633e
7e359d8
a6de31e
ee94e11
619ee4a
6f26810
7738916
a6bfba9
d468289
101af91
c6b65c5
972752d
760570c
7e53651
c79a96f
b81fd72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 110 in localization/ndt_scan_matcher/src/map_update_module.cpp
Codecov / codecov/patch
localization/ndt_scan_matcher/src/map_update_module.cpp#L110
Check warning on line 118 in localization/ndt_scan_matcher/src/map_update_module.cpp
Codecov / codecov/patch
localization/ndt_scan_matcher/src/map_update_module.cpp#L116-L118
Check warning on line 121 in localization/ndt_scan_matcher/src/map_update_module.cpp
Codecov / codecov/patch
localization/ndt_scan_matcher/src/map_update_module.cpp#L121
Check warning on line 449 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
Codecov / codecov/patch
localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp#L449
Check warning on line 451 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
Codecov / codecov/patch
localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp#L451
Check warning on line 453 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method