-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): enable multi channel tracker merger #7459
Merged
technolojin
merged 13 commits into
autowarefoundation:main
from
technolojin:feat/enable_multi_channel_tracker_merger
Jun 26, 2024
Merged
feat(tier4_perception_launch): enable multi channel tracker merger #7459
technolojin
merged 13 commits into
autowarefoundation:main
from
technolojin:feat/enable_multi_channel_tracker_merger
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Jun 12, 2024
3 tasks
technolojin
changed the title
feat(): enable multi channel tracker merger
feat(tier4_perception_launch): enable multi channel tracker merger
Jun 12, 2024
technolojin
force-pushed
the
feat/enable_multi_channel_tracker_merger
branch
6 times, most recently
from
June 19, 2024 08:32
fc9775d
to
814f95f
Compare
technolojin
force-pushed
the
feat/enable_multi_channel_tracker_merger
branch
from
June 20, 2024 06:31
e5ad3eb
to
90025b2
Compare
Signed-off-by: Taekjin LEE <[email protected]> feat: separate filters feat: filtering camera lidar fusion fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> fix: add missing config Signed-off-by: Taekjin LEE <[email protected]> fix: radar only mode for both fusion mode fix Signed-off-by: Taekjin LEE <[email protected]> style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
fix radar output Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
This commit updates the input paths for object detection. It ensures that the correct paths are used for the detection process. Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
technolojin
force-pushed
the
feat/enable_multi_channel_tracker_merger
branch
from
June 20, 2024 08:24
f806b2e
to
be8318f
Compare
technolojin
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 20, 2024
YoshiRi
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…utowarefoundation#7459) * feat: introduce multi channel tracker merger Signed-off-by: Taekjin LEE <[email protected]> feat: separate filters feat: filtering camera lidar fusion fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> fix: add missing config Signed-off-by: Taekjin LEE <[email protected]> fix: radar only mode for both fusion mode fix Signed-off-by: Taekjin LEE <[email protected]> style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: implement merger switching Signed-off-by: Taekjin LEE <[email protected]> * chore: move pointcloud filter from detection to filter group Signed-off-by: Taekjin LEE <[email protected]> * chore: define external and internal interfaces Signed-off-by: Taekjin LEE <[email protected]> * fix: set output of camera-lidar in absolute path Signed-off-by: Taekjin LEE <[email protected]> * chore: explicit object detection output Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths fix radar output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths Signed-off-by: Taekjin LEE <[email protected]> * fix: radar pipeline output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths This commit updates the input paths for object detection. It ensures that the correct paths are used for the detection process. Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: group to avoid argument mixture Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…utowarefoundation#7459) * feat: introduce multi channel tracker merger Signed-off-by: Taekjin LEE <[email protected]> feat: separate filters feat: filtering camera lidar fusion fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> fix: add missing config Signed-off-by: Taekjin LEE <[email protected]> fix: radar only mode for both fusion mode fix Signed-off-by: Taekjin LEE <[email protected]> style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: implement merger switching Signed-off-by: Taekjin LEE <[email protected]> * chore: move pointcloud filter from detection to filter group Signed-off-by: Taekjin LEE <[email protected]> * chore: define external and internal interfaces Signed-off-by: Taekjin LEE <[email protected]> * fix: set output of camera-lidar in absolute path Signed-off-by: Taekjin LEE <[email protected]> * chore: explicit object detection output Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths fix radar output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths Signed-off-by: Taekjin LEE <[email protected]> * fix: radar pipeline output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths This commit updates the input paths for object detection. It ensures that the correct paths are used for the detection process. Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: group to avoid argument mixture Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…utowarefoundation#7459) * feat: introduce multi channel tracker merger Signed-off-by: Taekjin LEE <[email protected]> feat: separate filters feat: filtering camera lidar fusion fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> fix: add missing config Signed-off-by: Taekjin LEE <[email protected]> fix: radar only mode for both fusion mode fix Signed-off-by: Taekjin LEE <[email protected]> style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: implement merger switching Signed-off-by: Taekjin LEE <[email protected]> * chore: move pointcloud filter from detection to filter group Signed-off-by: Taekjin LEE <[email protected]> * chore: define external and internal interfaces Signed-off-by: Taekjin LEE <[email protected]> * fix: set output of camera-lidar in absolute path Signed-off-by: Taekjin LEE <[email protected]> * chore: explicit object detection output Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths fix radar output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths Signed-off-by: Taekjin LEE <[email protected]> * fix: radar pipeline output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths This commit updates the input paths for object detection. It ensures that the correct paths are used for the detection process. Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: group to avoid argument mixture Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…utowarefoundation#7459) * feat: introduce multi channel tracker merger Signed-off-by: Taekjin LEE <[email protected]> feat: separate filters feat: filtering camera lidar fusion fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> fix: add missing config Signed-off-by: Taekjin LEE <[email protected]> fix: radar only mode for both fusion mode fix Signed-off-by: Taekjin LEE <[email protected]> style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: implement merger switching Signed-off-by: Taekjin LEE <[email protected]> * chore: move pointcloud filter from detection to filter group Signed-off-by: Taekjin LEE <[email protected]> * chore: define external and internal interfaces Signed-off-by: Taekjin LEE <[email protected]> * fix: set output of camera-lidar in absolute path Signed-off-by: Taekjin LEE <[email protected]> * chore: explicit object detection output Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths fix radar output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths Signed-off-by: Taekjin LEE <[email protected]> * fix: radar pipeline output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths This commit updates the input paths for object detection. It ensures that the correct paths are used for the detection process. Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: group to avoid argument mixture Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…7459) * feat: introduce multi channel tracker merger Signed-off-by: Taekjin LEE <[email protected]> feat: separate filters feat: filtering camera lidar fusion fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> fix: add missing config Signed-off-by: Taekjin LEE <[email protected]> fix: radar only mode for both fusion mode fix Signed-off-by: Taekjin LEE <[email protected]> style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: implement merger switching Signed-off-by: Taekjin LEE <[email protected]> * chore: move pointcloud filter from detection to filter group Signed-off-by: Taekjin LEE <[email protected]> * chore: define external and internal interfaces Signed-off-by: Taekjin LEE <[email protected]> * fix: set output of camera-lidar in absolute path Signed-off-by: Taekjin LEE <[email protected]> * chore: explicit object detection output Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths fix radar output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths Signed-off-by: Taekjin LEE <[email protected]> * fix: radar pipeline output Signed-off-by: Taekjin LEE <[email protected]> * chore: update object detection input paths This commit updates the input paths for object detection. It ensures that the correct paths are used for the detection process. Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: group to avoid argument mixture Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an perception option
use_multi_channel_tracker_merger
.This option replaces object merge pipeline to the multi-object-tracker multi input functionality.
The new pipeline will be tested.
This work is based on the perception launcher refactoring #7194
Tests performed
Effects on system behavior
Expected to get benefit of the new multi channel tracker merger.
Interface changes
The new argument
use_multi_channel_tracker_merger
will be added. Default value will befalse
that works as previous pipeline.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.