Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(clang-tidy-differential): fix tag requirement #7396

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 10, 2024

Description

Forgot to add the requirement condition to the workflow in:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx self-assigned this Jun 10, 2024
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 10, 2024
@xmfcx xmfcx added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:run-clang-tidy-differential and removed tag:run-clang-tidy-differential labels Jun 10, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Jun 10, 2024

image

Without tag, it won't work ✅

image

With tag, it works ✅

@xmfcx xmfcx added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 10, 2024
@xmfcx xmfcx merged commit 2334f63 into main Jun 10, 2024
62 checks passed
@xmfcx xmfcx deleted the ci/clang-tidy-fix branch June 10, 2024 06:28
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant