Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occlusion_spot_module): fix dependencies, docs, codeowners #7393

Merged
merged 2 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ planning/behavior_velocity_dynamic_obstacle_stop_module/** [email protected]
planning/behavior_velocity_intersection_module/** [email protected] [email protected] [email protected] [email protected] [email protected]
planning/behavior_velocity_no_drivable_lane_module/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
planning/behavior_velocity_no_stopping_area_module/** [email protected] [email protected] [email protected]
planning/behavior_velocity_occlusion_spot_module/** [email protected] [email protected] [email protected]
planning/autoware_behavior_velocity_occlusion_spot_module/** [email protected] [email protected] [email protected]
planning/autoware_behavior_velocity_planner_common/** [email protected] [email protected] [email protected] [email protected] [email protected]
planning/autoware_behavior_velocity_run_out_module/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
planning/behavior_velocity_speed_bump_module/** [email protected] [email protected] [email protected]
Expand Down
2 changes: 1 addition & 1 deletion planning/.pages
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ nav:
- 'Intersection': planning/autoware_behavior_velocity_intersection_module
- 'No Drivable Lane': planning/behavior_velocity_no_drivable_lane_module
- 'No Stopping Area': planning/behavior_velocity_no_stopping_area_module
- 'Occlusion Spot': planning/behavior_velocity_occlusion_spot_module
- 'Occlusion Spot': planning/autoware_behavior_velocity_occlusion_spot_module
- 'Run Out': planning/autoware_behavior_velocity_run_out_module
- 'Speed Bump': planning/behavior_velocity_speed_bump_module
- 'Stop Line': planning/autoware_behavior_velocity_stop_line_module
Expand Down
2 changes: 1 addition & 1 deletion planning/autoware_behavior_velocity_planner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ It loads modules as plugins. Please refer to the links listed below for detail o
- [Stop Line](../autoware_behavior_velocity_stop_line_module/README.md)
- [Virtual Traffic Light](../autoware_behavior_velocity_virtual_traffic_light_module/README.md)
- [Traffic Light](../behavior_velocity_traffic_light_module/README.md)
- [Occlusion Spot](../behavior_velocity_occlusion_spot_module/README.md)
- [Occlusion Spot](../autoware_behavior_velocity_occlusion_spot_module/README.md)
- [No Stopping Area](../behavior_velocity_no_stopping_area_module/README.md)
- [Run Out](../autoware_behavior_velocity_run_out_module/README.md)
- [Speed Bump](../behavior_velocity_speed_bump_module/README.md)
Expand Down
2 changes: 1 addition & 1 deletion planning/autoware_behavior_velocity_planner/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
<test_depend>ament_cmake_ros</test_depend>
<test_depend>ament_lint_auto</test_depend>
<test_depend>autoware_behavior_velocity_intersection_module</test_depend>
<test_depend>autoware_behavior_velocity_occlusion_spot_module</test_depend>
<test_depend>autoware_behavior_velocity_run_out_module</test_depend>
<test_depend>autoware_behavior_velocity_stop_line_module</test_depend>
<test_depend>autoware_behavior_velocity_virtual_traffic_light_module</test_depend>
Expand All @@ -76,7 +77,6 @@
<test_depend>behavior_velocity_detection_area_module</test_depend>
<test_depend>behavior_velocity_no_drivable_lane_module</test_depend>
<test_depend>behavior_velocity_no_stopping_area_module</test_depend>
<test_depend>behavior_velocity_occlusion_spot_module</test_depend>
<test_depend>behavior_velocity_speed_bump_module</test_depend>
<test_depend>behavior_velocity_traffic_light_module</test_depend>
<!--<test_depend>autoware_behavior_velocity_template_module</test_depend>-->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ std::shared_ptr<BehaviorVelocityPlannerNode> generateNode()
get_behavior_velocity_module_config_no_prefix("detection_area"),
get_behavior_velocity_module_config("intersection"),
get_behavior_velocity_module_config_no_prefix("no_stopping_area"),
get_behavior_velocity_module_config_no_prefix("occlusion_spot"),
get_behavior_velocity_module_config("occlusion_spot"),
get_behavior_velocity_module_config("run_out"),
get_behavior_velocity_module_config_no_prefix("speed_bump"),
get_behavior_velocity_module_config("stop_line"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ APPROACH --> APPROACH : Approach duration is less than threshold
##### Limit velocity with specified jerk and acc limit

The maximum slowdown velocity is calculated in order not to slowdown too much.
See the [Occlusion Spot document](../behavior_velocity_occlusion_spot_module/#maximum-slowdown-velocity) for more details.
See the [Occlusion Spot document](../autoware_behavior_velocity_occlusion_spot_module/#maximum-slowdown-velocity) for more details.
You can choose whether to use this feature by parameter of `slow_down_limit.enable`.

### Module Parameters
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<library path="behavior_velocity_occlusion_spot_module">
<library path="autoware_behavior_velocity_occlusion_spot_module">
<class type="autoware::behavior_velocity_planner::OcclusionSpotModulePlugin" base_class_type="autoware::behavior_velocity_planner::PluginInterface"/>
</library>
Loading