Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): enable low_intensity_filter as default #7390

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jun 10, 2024

Description

Related links

Tests performed

image

  • Confirmed that there is no degredation by Internal-evalutator tool:(camera_lidar_fusion_mode)
Before After
image image

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 10, 2024
@badai-nguyen badai-nguyen added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 10, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review June 10, 2024 02:58
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just within code. Do you want me to run this with my environment?

@badai-nguyen
Copy link
Contributor Author

badai-nguyen commented Jun 12, 2024

Do you want me to run this with my environment?

@YoshiRi Thanks for your reivew. Since I have already checked this change on Evaluator so I think this should be fine.

@badai-nguyen badai-nguyen enabled auto-merge (squash) June 12, 2024 04:30
@badai-nguyen badai-nguyen disabled auto-merge June 12, 2024 04:31
@badai-nguyen badai-nguyen enabled auto-merge (squash) June 12, 2024 06:20
@badai-nguyen badai-nguyen merged commit ab4badb into autowarefoundation:main Jun 12, 2024
24 checks passed
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants