Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pid_longitudinal_controller)!: prefix package and namespace with autoware #7383

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 8, 2024

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

autowarefoundation/autoware#4569

Tests performed

psim

Effects on system behavior

Nothing

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 8, 2024
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 8, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review June 8, 2024 16:59
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 merged commit a082e64 into autowarefoundation:main Jun 8, 2024
22 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/autoware-prefix-pid branch June 8, 2024 18:43
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…with autoware (#7383)

* add prefix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix trajectory follower node param

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant