refactor(route_handler): route handler add autoware prefix #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…efix Signed-off-by: mohammad alqudah <[email protected]>
mkquda
added
the
component:planning
mkquda
requested review from
rej55,
shmpwk,
taikitanaka3,
TakaHoribe,
tkimura4,
go-sakayori,
kosuke55,
soblin,
isamu-takagi,
mitsudome-r,
mehmetdogru,
mkuri,
TomohitoAndo,
maxime-clem,
ahmeddesokyebrahim,
kyoichi-sugahara,
yuki-takagi-66 and
danielsanchezaran
as code owners
github-actions
bot
added
type:documentation
Signed-off-by: mohammad alqudah <[email protected]>
maxime-clem
reviewed
Jun 7, 2024
planning/autoware_route_handler/include/autoware_route_handler/autoware_route_handler.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: mohammad alqudah <[email protected]>
satoshi-ota
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Looks good. Btw, could you fix this package as well? It also depends route_handler.
https://github.com/autowarefoundation/autoware_tools/blob/95dc81f032cc7064cff584f319306e3fdacaf89d/driving_environment_analyzer/package.xml#L34
7 tasks
…efix Signed-off-by: mohammad alqudah <[email protected]>
soblin
approved these changes
Jun 10, 2024
rej55
approved these changes
Jun 10, 2024
mkquda
added
the
run:build-and-test-differential
takayuki5168
approved these changes
Jun 10, 2024
…efix Signed-off-by: mohammad alqudah <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* rename route handler package Signed-off-by: mohammad alqudah <[email protected]> * update packages dependencies Signed-off-by: mohammad alqudah <[email protected]> * update include guards Signed-off-by: mohammad alqudah <[email protected]> * update includes Signed-off-by: mohammad alqudah <[email protected]> * put in autoware namespace Signed-off-by: mohammad alqudah <[email protected]> * fix formats Signed-off-by: mohammad alqudah <[email protected]> * keep header and source file name as before Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests performed
Tested on psim
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.