Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(openai-pr-reviewer): remove the action #7332

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 6, 2024

User description

Description

We now use https://github.com/Codium-ai/pr-agent with the pr-agent.yaml workflow.

This old workflow switched to a weird paid model: https://github.com/coderabbitai/ai-pr-reviewer and this old one is archived.

Let's remove it and use the PR agent. We can give it our token too. I will create a new PR to make it use GPT4o too.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.


PR Type

configuration changes, other


Description

  • Removed the openai-pr-reviewer GitHub Action workflow configuration.
  • Deleted permissions, triggers, concurrency settings, and job definitions related to the openai-pr-reviewer.
  • This change is made to switch to using the pr-agent workflow instead.

Changes walkthrough 📝

Relevant files
Configuration changes
openai-pr-reviewer.yaml
Remove `openai-pr-reviewer` GitHub Action workflow             

.github/workflows/openai-pr-reviewer.yaml

  • Removed the entire workflow configuration for openai-pr-reviewer.
  • Deleted permissions, triggers, concurrency settings, and job
    definitions.
  • +0/-39   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @xmfcx xmfcx added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
    @xmfcx xmfcx requested review from yukkysaito and mitsudome-r June 6, 2024 16:20
    @xmfcx xmfcx self-assigned this Jun 6, 2024
    @github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 6, 2024
    @xmfcx xmfcx added the tag:pr-agent Mark to enable PR-Agent for automated reviews. (used-by-ci) label Jun 6, 2024
    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 6, 2024

    @xmfcx xmfcx added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 6, 2024
    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 6, 2024

    /describe

    Copy link

    github-actions bot commented Jun 6, 2024

    PR Description updated to latest commit (4877bc0)

    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 6, 2024

    /review

    Copy link

    github-actions bot commented Jun 6, 2024

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the PR involves a straightforward removal of a workflow file without complex dependencies or intricate logic.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Code feedback:

    @xmfcx
    Copy link
    Contributor Author

    xmfcx commented Jun 6, 2024

    /ask Why should @yukkysaito approve this PR?

    Copy link

    github-actions bot commented Jun 6, 2024

    Ask

    why should @yukkysaito approve this pr?

    Answer:

    @yukkysaito should approve this PR because it removes an outdated and now paid workflow for AI-based code review and replaces it with a more suitable and currently used alternative, the Codium-ai PR agent. This change aligns with the project's current practices and ensures that the code review process remains efficient and cost-effective. Additionally, the removal of the old workflow eliminates potential confusion and maintenance overhead associated with an archived and unsupported tool.

    @xmfcx xmfcx merged commit a749eda into main Jun 6, 2024
    63 of 66 checks passed
    @xmfcx xmfcx deleted the ci/remove-openai-pr-reviewer branch June 6, 2024 17:32
    KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tag:pr-agent Mark to enable PR-Agent for automated reviews. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
    Projects
    No open projects
    Status: Done
    Development

    Successfully merging this pull request may close these issues.

    1 participant