-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mrm_emergency_stop_operator): improve readability and change to read topic by polling #7313
Conversation
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Could you review this PR as a code owner? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7313 +/- ##
===========================================
+ Coverage 15.09% 28.63% +13.53%
===========================================
Files 1967 1593 -374
Lines 135941 116056 -19885
Branches 42122 49470 +7348
===========================================
+ Hits 20520 33227 +12707
+ Misses 92700 73913 -18787
+ Partials 22721 8916 -13805
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Description
Based on the discussion, change emergency_handler and mrm_handler to read topic by polling instead of best_effort callback.
In addition, readability was improved by reducing variable reuse.
Tests performed
psim test were performed
Effects on system behavior
nothing
Interface changes
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.