refactor(ndt scan matcher): update parameter #7276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
YamatoAndo
requested review from
anhnv3991,
KYabuuchi,
kminoda,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
github-actions
bot
added
type:documentation
4 tasks
SakodaShintaro
added
the
tag:run-build-and-test-differential
SakodaShintaro
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Looks Good To Me
I don't think this should be fixed in this pull request, but I'll leave one comment.
Currently, distance_initial_to_result is evaluated only in the y direction in Driving Log Replayer.
https://github.com/SakodaShintaro/driving_log_replayer/blob/024ab5df20ef12cbe6358762dd23cb26fa943c63/driving_log_replayer/driving_log_replayer/localization.py#L92
In autoware.universe, the norm of all xyz is used, so these are not the same.
It is not yet clear which is the better indicator.
|
@YamatoAndo This is a very minor suggestion, there are diffs of the yaml file in universe and launch.
|
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
* rename to sensor_points.timeout_sec Signed-off-by: Yamato Ando <[email protected]> * parameterize skipping_publish_num Signed-off-by: Yamato Ando <[email protected]> * fix readme Signed-off-by: Yamato Ando <[email protected]> * parameterize sinitial_to_result_distance_tolerance_m Signed-off-by: Yamato Ando <[email protected]> * fix build error Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* rename to sensor_points.timeout_sec Signed-off-by: Yamato Ando <[email protected]> * parameterize skipping_publish_num Signed-off-by: Yamato Ando <[email protected]> * fix readme Signed-off-by: Yamato Ando <[email protected]> * parameterize sinitial_to_result_distance_tolerance_m Signed-off-by: Yamato Ando <[email protected]> * fix build error Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
validation.lidar_topic_timeout_sectosensor_points.timeout_secvalidation.initial_to_result_distance_tolerance_mvalidation.skipping_publish_numTests performed
LSim works.
Effects on system behavior
Not applicable.
Interface changes
rename a parameter
validation.lidar_topic_timeout_sectosensor_points.timeout_secadd new parameters
validation.initial_to_result_distance_tolerance_mvalidation.skipping_publish_numPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.