-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi_object_tracker): tracker refactoring #7271
Merged
technolojin
merged 31 commits into
autowarefoundation:main
from
technolojin:feat/mot_tracker_refactoring
Jun 23, 2024
Merged
feat(multi_object_tracker): tracker refactoring #7271
technolojin
merged 31 commits into
autowarefoundation:main
from
technolojin:feat/mot_tracker_refactoring
Jun 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
label
Jun 5, 2024
|
technolojin
force-pushed
the
feat/mot_tracker_refactoring
branch
7 times, most recently
from
June 11, 2024 08:52
acd5199
to
74f4594
Compare
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Jun 11, 2024
technolojin
force-pushed
the
feat/mot_tracker_refactoring
branch
from
June 13, 2024 00:54
74f4594
to
f30060e
Compare
github-actions
bot
removed
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Jun 13, 2024
7 tasks
technolojin
force-pushed
the
feat/mot_tracker_refactoring
branch
from
June 18, 2024 06:50
87bf4c9
to
2aba1eb
Compare
technolojin
force-pushed
the
feat/mot_tracker_refactoring
branch
2 times, most recently
from
June 20, 2024 02:29
cb1845a
to
8008bd2
Compare
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
technolojin
force-pushed
the
feat/mot_tracker_refactoring
branch
from
June 20, 2024 04:06
8008bd2
to
3f20c98
Compare
technolojin
added
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
and removed
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
labels
Jun 21, 2024
yukkysaito
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
) * feat: separate filters Signed-off-by: Taekjin LEE <[email protected]> * fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> * fix: replace xyzrpy covariance index Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor tracker class members Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring destructor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring getUpdatingObject Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring object size checker Signed-off-by: Taekjin LEE <[email protected]> * fix: debugger delay calculation order is fixed Signed-off-by: Taekjin LEE <[email protected]> * fix: bicycle size update bug fix Signed-off-by: Taekjin LEE <[email protected]> * fix: renamed message package Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring Signed-off-by: Taekjin LEE <[email protected]> * feat: object parameter class Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor includes Signed-off-by: Taekjin LEE <[email protected]> * feat: initial impl. of object model Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to bicycle, big, normal Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to pedestrian Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. cont Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: fix missing refactoring Signed-off-by: Taekjin LEE <[email protected]> * fix: align unit of angles, yaw rates Signed-off-by: Taekjin LEE <[email protected]> * fix: rename tier4_autoware_utils to autoware_universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: missing unit conversion Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: sources Signed-off-by: Taekjin LEE <[email protected]> * chore: Update include and import statements Signed-off-by: Taekjin LEE <[email protected]> * fix: unit convert bug Signed-off-by: Taekjin LEE <[email protected]> * fix: update to autoware::universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: mis-implementation of process noise Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Simon Eisenmann <[email protected]>
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
Jun 27, 2024
) * feat: separate filters Signed-off-by: Taekjin LEE <[email protected]> * fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> * fix: replace xyzrpy covariance index Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor tracker class members Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring destructor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring getUpdatingObject Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring object size checker Signed-off-by: Taekjin LEE <[email protected]> * fix: debugger delay calculation order is fixed Signed-off-by: Taekjin LEE <[email protected]> * fix: bicycle size update bug fix Signed-off-by: Taekjin LEE <[email protected]> * fix: renamed message package Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring Signed-off-by: Taekjin LEE <[email protected]> * feat: object parameter class Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor includes Signed-off-by: Taekjin LEE <[email protected]> * feat: initial impl. of object model Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to bicycle, big, normal Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to pedestrian Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. cont Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: fix missing refactoring Signed-off-by: Taekjin LEE <[email protected]> * fix: align unit of angles, yaw rates Signed-off-by: Taekjin LEE <[email protected]> * fix: rename tier4_autoware_utils to autoware_universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: missing unit conversion Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: sources Signed-off-by: Taekjin LEE <[email protected]> * chore: Update include and import statements Signed-off-by: Taekjin LEE <[email protected]> * fix: unit convert bug Signed-off-by: Taekjin LEE <[email protected]> * fix: update to autoware::universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: mis-implementation of process noise Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Taekjin LEE <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
) * feat: separate filters Signed-off-by: Taekjin LEE <[email protected]> * fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> * fix: replace xyzrpy covariance index Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor tracker class members Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring destructor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring getUpdatingObject Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring object size checker Signed-off-by: Taekjin LEE <[email protected]> * fix: debugger delay calculation order is fixed Signed-off-by: Taekjin LEE <[email protected]> * fix: bicycle size update bug fix Signed-off-by: Taekjin LEE <[email protected]> * fix: renamed message package Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring Signed-off-by: Taekjin LEE <[email protected]> * feat: object parameter class Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor includes Signed-off-by: Taekjin LEE <[email protected]> * feat: initial impl. of object model Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to bicycle, big, normal Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to pedestrian Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. cont Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: fix missing refactoring Signed-off-by: Taekjin LEE <[email protected]> * fix: align unit of angles, yaw rates Signed-off-by: Taekjin LEE <[email protected]> * fix: rename tier4_autoware_utils to autoware_universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: missing unit conversion Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: sources Signed-off-by: Taekjin LEE <[email protected]> * chore: Update include and import statements Signed-off-by: Taekjin LEE <[email protected]> * fix: unit convert bug Signed-off-by: Taekjin LEE <[email protected]> * fix: update to autoware::universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: mis-implementation of process noise Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat: separate filters Signed-off-by: Taekjin LEE <[email protected]> * fix: object validator to modular Signed-off-by: Taekjin LEE <[email protected]> * fix: replace xyzrpy covariance index Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor tracker class members Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring destructor Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring getUpdatingObject Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring object size checker Signed-off-by: Taekjin LEE <[email protected]> * fix: debugger delay calculation order is fixed Signed-off-by: Taekjin LEE <[email protected]> * fix: bicycle size update bug fix Signed-off-by: Taekjin LEE <[email protected]> * fix: renamed message package Signed-off-by: Taekjin LEE <[email protected]> * chore: refactoring Signed-off-by: Taekjin LEE <[email protected]> * feat: object parameter class Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: refactor includes Signed-off-by: Taekjin LEE <[email protected]> * feat: initial impl. of object model Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to bicycle, big, normal Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. object model to pedestrian Signed-off-by: Taekjin LEE <[email protected]> * feat: impl. cont Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * chore: fix missing refactoring Signed-off-by: Taekjin LEE <[email protected]> * fix: align unit of angles, yaw rates Signed-off-by: Taekjin LEE <[email protected]> * fix: rename tier4_autoware_utils to autoware_universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: missing unit conversion Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <[email protected]> * fix: sources Signed-off-by: Taekjin LEE <[email protected]> * chore: Update include and import statements Signed-off-by: Taekjin LEE <[email protected]> * fix: unit convert bug Signed-off-by: Taekjin LEE <[email protected]> * fix: update to autoware::universe_utils Signed-off-by: Taekjin LEE <[email protected]> * fix: mis-implementation of process noise Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
debug: bicycle tracker object size update
measureWithShape
The incoming
object
size was not used, but default value was.chore: refactoring
utils.hpp
By the changes of above, unused functions are removed.
Also, the covariance indexes are replaced by indexes definded by
tier4_autoware_utils
. It does not change actual implementation.chore: overall refactoring to resolve
clang-tidy
warnings (not everything)This PR will follow merge of PR #7170
Tests performed
Tested under TIER IV evaluator
Test result : TIER IV INTERNAL sim_tracking 20/20
Effects on system behavior
Should not be changed.
Interface changes
Not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.