Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): tracker refactoring #7271

Merged

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jun 5, 2024

Description

  1. debug: bicycle tracker object size update measureWithShape
    The incoming object size was not used, but default value was.

  2. chore: refactoring utils.hpp
    By the changes of above, unused functions are removed.
    Also, the covariance indexes are replaced by indexes definded by tier4_autoware_utils. It does not change actual implementation.

  3. chore: overall refactoring to resolve clang-tidy warnings (not everything)

This PR will follow merge of PR #7170

Tests performed

Tested under TIER IV evaluator
Test result : TIER IV INTERNAL sim_tracking 20/20

Effects on system behavior

Should not be changed.

Interface changes

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 5, 2024
Copy link

mergify bot commented Jun 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #7170. Mergify cannot evaluate rules on this PR. ⚠️

@technolojin technolojin force-pushed the feat/mot_tracker_refactoring branch 7 times, most recently from acd5199 to 74f4594 Compare June 11, 2024 08:52
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 11, 2024
@technolojin technolojin force-pushed the feat/mot_tracker_refactoring branch from 74f4594 to f30060e Compare June 13, 2024 00:54
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 13, 2024
@technolojin technolojin force-pushed the feat/mot_tracker_refactoring branch from 87bf4c9 to 2aba1eb Compare June 18, 2024 06:50
@technolojin technolojin self-assigned this Jun 18, 2024
@technolojin technolojin force-pushed the feat/mot_tracker_refactoring branch 2 times, most recently from cb1845a to 8008bd2 Compare June 20, 2024 02:29
@technolojin technolojin force-pushed the feat/mot_tracker_refactoring branch from 8008bd2 to 3f20c98 Compare June 20, 2024 04:06
@technolojin technolojin marked this pull request as ready for review June 21, 2024 05:33
@technolojin technolojin added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jun 21, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 6ac4b24 into autowarefoundation:main Jun 23, 2024
46 of 47 checks passed
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
)

* feat: separate filters

Signed-off-by: Taekjin LEE <[email protected]>

* fix: object validator to modular

Signed-off-by: Taekjin LEE <[email protected]>

* fix: replace xyzrpy covariance index

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor tracker class members

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring destructor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring getUpdatingObject

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring object size checker

Signed-off-by: Taekjin LEE <[email protected]>

* fix: debugger delay calculation order is fixed

Signed-off-by: Taekjin LEE <[email protected]>

* fix: bicycle size update bug fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: renamed message package

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* feat: object parameter class

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor includes

Signed-off-by: Taekjin LEE <[email protected]>

* feat: initial impl. of object model

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to bicycle, big, normal

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to pedestrian

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. cont

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: fix missing refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* fix: align unit of angles, yaw rates

Signed-off-by: Taekjin LEE <[email protected]>

* fix: rename tier4_autoware_utils to autoware_universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: missing unit conversion

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: sources

Signed-off-by: Taekjin LEE <[email protected]>

* chore: Update include and import statements

Signed-off-by: Taekjin LEE <[email protected]>

* fix: unit convert bug

Signed-off-by: Taekjin LEE <[email protected]>

* fix: update to autoware::universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: mis-implementation of process noise

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Simon Eisenmann <[email protected]>
technolojin added a commit to technolojin/autoware.universe that referenced this pull request Jun 27, 2024
)

* feat: separate filters

Signed-off-by: Taekjin LEE <[email protected]>

* fix: object validator to modular

Signed-off-by: Taekjin LEE <[email protected]>

* fix: replace xyzrpy covariance index

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor tracker class members

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring destructor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring getUpdatingObject

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring object size checker

Signed-off-by: Taekjin LEE <[email protected]>

* fix: debugger delay calculation order is fixed

Signed-off-by: Taekjin LEE <[email protected]>

* fix: bicycle size update bug fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: renamed message package

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* feat: object parameter class

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor includes

Signed-off-by: Taekjin LEE <[email protected]>

* feat: initial impl. of object model

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to bicycle, big, normal

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to pedestrian

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. cont

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: fix missing refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* fix: align unit of angles, yaw rates

Signed-off-by: Taekjin LEE <[email protected]>

* fix: rename tier4_autoware_utils to autoware_universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: missing unit conversion

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: sources

Signed-off-by: Taekjin LEE <[email protected]>

* chore: Update include and import statements

Signed-off-by: Taekjin LEE <[email protected]>

* fix: unit convert bug

Signed-off-by: Taekjin LEE <[email protected]>

* fix: update to autoware::universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: mis-implementation of process noise

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Taekjin LEE <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
)

* feat: separate filters

Signed-off-by: Taekjin LEE <[email protected]>

* fix: object validator to modular

Signed-off-by: Taekjin LEE <[email protected]>

* fix: replace xyzrpy covariance index

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor tracker class members

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring destructor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring getUpdatingObject

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring object size checker

Signed-off-by: Taekjin LEE <[email protected]>

* fix: debugger delay calculation order is fixed

Signed-off-by: Taekjin LEE <[email protected]>

* fix: bicycle size update bug fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: renamed message package

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* feat: object parameter class

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor includes

Signed-off-by: Taekjin LEE <[email protected]>

* feat: initial impl. of object model

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to bicycle, big, normal

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to pedestrian

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. cont

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: fix missing refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* fix: align unit of angles, yaw rates

Signed-off-by: Taekjin LEE <[email protected]>

* fix: rename tier4_autoware_utils to autoware_universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: missing unit conversion

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: sources

Signed-off-by: Taekjin LEE <[email protected]>

* chore: Update include and import statements

Signed-off-by: Taekjin LEE <[email protected]>

* fix: unit convert bug

Signed-off-by: Taekjin LEE <[email protected]>

* fix: update to autoware::universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: mis-implementation of process noise

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* feat: separate filters

Signed-off-by: Taekjin LEE <[email protected]>

* fix: object validator to modular

Signed-off-by: Taekjin LEE <[email protected]>

* fix: replace xyzrpy covariance index

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor tracker class members

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring destructor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring getUpdatingObject

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring object size checker

Signed-off-by: Taekjin LEE <[email protected]>

* fix: debugger delay calculation order is fixed

Signed-off-by: Taekjin LEE <[email protected]>

* fix: bicycle size update bug fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: renamed message package

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* feat: object parameter class

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor includes

Signed-off-by: Taekjin LEE <[email protected]>

* feat: initial impl. of object model

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to bicycle, big, normal

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to pedestrian

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. cont

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: fix missing refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* fix: align unit of angles, yaw rates

Signed-off-by: Taekjin LEE <[email protected]>

* fix: rename tier4_autoware_utils to autoware_universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: missing unit conversion

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: sources

Signed-off-by: Taekjin LEE <[email protected]>

* chore: Update include and import statements

Signed-off-by: Taekjin LEE <[email protected]>

* fix: unit convert bug

Signed-off-by: Taekjin LEE <[email protected]>

* fix: update to autoware::universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: mis-implementation of process noise

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@technolojin technolojin deleted the feat/mot_tracker_refactoring branch July 26, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants