Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add a workflow for DCO check to avoid DCO bot system failure #7270

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jun 5, 2024

Signed-off-by: Kotaro Yoshimoto [email protected]

Description

DCO check is not working now.
image

dcoapp/app#211

Alternatively, I added this workflow as proposed in the issue.

Tests performed

Well done!
https://github.com/autowarefoundation/autoware.universe/actions/runs/9377200258/job/25818372246

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 5, 2024
HansRobo and others added 2 commits June 5, 2024 11:03
Signed-off-by: Kotaro Yoshimoto <[email protected]>
@HansRobo HansRobo marked this pull request as ready for review June 5, 2024 02:25
@HansRobo HansRobo added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 5, 2024
@HansRobo
Copy link
Member Author

HansRobo commented Jun 5, 2024

Additional TODOs for maintainers

  • Remove conventional DCO check from required CIs
  • Add new workflow to required CIs

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robo-san, I will add it 👍

@xmfcx xmfcx merged commit 9ec94f0 into main Jun 5, 2024
36 checks passed
@xmfcx xmfcx deleted the add-dco-bot branch June 5, 2024 11:17
@xmfcx
Copy link
Contributor

xmfcx commented Jun 5, 2024

image
@HansRobo

@xmfcx
Copy link
Contributor

xmfcx commented Jun 5, 2024

Had to make it "dco"
image

Now it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants