Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace autoware_auto_msgs with autoware_msgs for vehicle modules #7251

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

mitsudome-r
Copy link
Member

Description

This is a subset of #6893 to make it easier to review.
This includes all the modification for vehicle directory in the original PR.

Related links

#6893
https://github.com/orgs/autowarefoundation/discussions/3862

Tests performed

Notes for reviewers

Interface changes

Message types are modified according to the table in this comment.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Jun 3, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation that there is no change in logic, just a replacement process.

@yukkysaito
Copy link
Contributor

Also there is no _auto_msgs in vehicle folder

@yukkysaito yukkysaito added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 4, 2024
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
@yukkysaito yukkysaito force-pushed the autoware_msg_vehicle branch from b4ef84b to c08789d Compare June 4, 2024 16:04
@yukkysaito yukkysaito enabled auto-merge (squash) June 4, 2024 16:09
@yukkysaito yukkysaito disabled auto-merge June 4, 2024 16:09
@yukkysaito yukkysaito merged commit 427d566 into main Jun 4, 2024
20 of 22 checks passed
@yukkysaito yukkysaito deleted the autoware_msg_vehicle branch June 4, 2024 16:17
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…les (autowarefoundation#7251)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…les (#7251)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants