Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace autoware_auto_msgs with autoware_msgs for map modules #7244

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat!: replace autoware_auto_msgs with autoware_msgs for map modules #7244

merged 1 commit into from
Jun 4, 2024

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 3, 2024 •
edited by xmfcx
Loading

Description

This is subset of #6893 to make it easier to review.
This includes all the modification for map directory in the original PR.

Depends on:

Related links

#6893
https://github.com/orgs/autowarefoundation/discussions/3862

Tests performed

Notes for reviewers

Interface changes

Message types are modified according to the table in this comment.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r @cyn-liu
@NorahXiong @beginningfan
feat!: replace autoware_auto_msgs with autoware_msgs for map modules
98f9aae 
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Jun 3, 2024
@mitsudome-r mitsudome-r requested a review from xmfcx June 3, 2024 16:27
@xmfcx xmfcx added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7244/
Modified URLs:

@xmfcx xmfcx mentioned this pull request Jun 4, 2024
Merged
7 tasks
@xmfcx
Copy link
Contributor

xmfcx commented Jun 4, 2024

Compiled (for the packages in the map directory) on my machine, the packages: map_height_fitter map_loader map_projection_loader map_tf_generator.

Also no reference is left to _auto msgs in the map directory.

The changes are just simple name/type refactors.

I think we can merge this.

@xmfcx
Copy link
Contributor

xmfcx commented Jun 4, 2024

Merging even though the checks are not passing. The build and test differential test is looking for --packages-above-and-dependencies thus failing for forward dependencies. They will be handled in the other PRs.

@xmfcx xmfcx merged commit 2332541 into main Jun 4, 2024
46 of 53 checks passed
@xmfcx xmfcx deleted the autoware_msg_map branch June 4, 2024 12:50
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
@mitsudome-r @cyn-liu
@NorahXiong @beginningfan @a-maumau
feat!: replace autoware_auto_msgs with autoware_msgs for map modules (a…
df91a2c 
…utowarefoundation#7244)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@mitsudome-r @cyn-liu
@NorahXiong @beginningfan @KhalilSelyan
feat!: replace autoware_auto_msgs with autoware_msgs for map modules (#…
17c3b42 
…7244)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi

@Motsu-san Motsu-san Awaiting requested review from Motsu-san

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

@kminoda kminoda Awaiting requested review from kminoda

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

Assignees

@mitsudome-r mitsudome-r

Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitsudome-r @xmfcx