Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replace autoware_auto_msgs with autoware_msgs for control modules #7240

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat!: replace autoware_auto_msgs with autoware_msgs for control modules #7240

merged 1 commit into from
Jun 4, 2024

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 3, 2024 •
edited by xmfcx
Loading

Description

This is subset of #6893 to make it easier to review.
This includes all the modification for control directory in the original PR.

Related links

#6893
https://github.com/orgs/autowarefoundation/discussions/3862

Tests performed

Notes for reviewers

Interface changes

Message types are modified according to the table in this comment.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jun 3, 2024
@xmfcx xmfcx added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 4, 2024
@xmfcx xmfcx mentioned this pull request Jun 4, 2024
Merged
7 tasks
@mitsudome-r @cyn-liu
@NorahXiong @beginningfan @xmfcx
feat!: replace autoware_auto_msgs with autoware_msgs for control modules
62239cb 
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
@xmfcx xmfcx force-pushed the autoware_msg_control branch from 7b50687 to 62239cb Compare June 4, 2024 15:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7240/
Modified URLs:

@xmfcx
Copy link
Contributor

xmfcx commented Jun 4, 2024

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-up-to autonomous_emergency_braking control_performance_analysis control_validator external_cmd_selector joy_controller lane_departure_checker mpc_lateral_controller obstacle_collision_checker operation_mode_transition_manager pid_longitudinal_controller predicted_path_checker pure_pursuit shift_decider smart_mpc_trajectory_follower trajectory_follower_base trajectory_follower_node vehicle_cmd_gate
was successful.
No autoware_auto references were left in the control folder.

@xmfcx xmfcx merged commit ce55d60 into main Jun 4, 2024
24 of 28 checks passed
@xmfcx xmfcx deleted the autoware_msg_control branch June 4, 2024 15:34
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
@mitsudome-r @cyn-liu
@NorahXiong @beginningfan @a-maumau
feat!: replace autoware_auto_msgs with autoware_msgs for control modu…
d3ecfbf 
…les (autowarefoundation#7240)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@mitsudome-r @cyn-liu
@NorahXiong @beginningfan @KhalilSelyan
feat!: replace autoware_auto_msgs with autoware_msgs for control modu…
01f279f 
…les (#7240)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@brkay54 brkay54 Awaiting requested review from brkay54

@soblin soblin Awaiting requested review from soblin

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@mkuri mkuri Awaiting requested review from mkuri

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

Assignees

@mitsudome-r mitsudome-r

Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitsudome-r @xmfcx