Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pose_covariance_modifier): change log output from screen to both #7198

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 31, 2024

Description

Change the log output of map/autoware_pose_covariance_modifier from screen to both, which outputs to both the terminal and the log file.

Tests performed

I checked both the terminal and the log file will receive the log output.

The log file when the running process get killed:

1717145744.0147877 [autoware_pose_covariance_modifier_node-1] *** Aborted at 1717145744 (unix time) try "date -d @1717145744" if you are using GNU date ***
1717145744.0152378 [autoware_pose_covariance_modifier_node-1] PC: @                0x0 (unknown)
1717145744.0154388 [autoware_pose_covariance_modifier_node-1] *** SIGTERM (@0x3e8000e1b20) received by PID 3217244 (TID 0x7fc0af44b680) from PID 924448; stack trace: ***
1717145744.0159378 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0afa3f4d6 google::(anonymous namespace)::FailureSignalHandler()
1717145744.0163515 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0af819ded rclcpp::SignalHandler::signal_handler()
1717145744.0165627 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aee42520 (unknown)
1717145744.0167651 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aee91117 (unknown)
1717145744.0169644 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aee93a41 pthread_cond_wait
1717145744.0171747 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aed84a8d ddsrt_cond_wait
1717145744.0173826 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aed84b55 ddsrt_cond_waituntil
1717145744.0175879 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aed6b45d (unknown)
1717145744.0177932 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0af13e74f rmw_wait
1717145744.0181944 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0af943848 rcl_wait
1717145744.0184586 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0af7611b6 rclcpp::Executor::wait_for_work()
1717145744.0188034 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0af7616d3 rclcpp::Executor::get_next_executable()
1717145744.0191271 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0af765c81 rclcpp::executors::SingleThreadedExecutor::spin()
1717145744.0192802 [autoware_pose_covariance_modifier_node-1]     @     0x5616980c8486 main
1717145744.0194256 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aee29d90 (unknown)
1717145744.0195649 [autoware_pose_covariance_modifier_node-1]     @     0x7fc0aee29e40 __libc_start_main
1717145744.0196309 [autoware_pose_covariance_modifier_node-1]     @     0x5616980c8e35 _start
1717145744.0205069 [ERROR] [autoware_pose_covariance_modifier_node-1]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@a-maumau a-maumau requested a review from meliketanrikulu as a code owner May 31, 2024 09:08
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 31, 2024
@meliketanrikulu
Copy link
Contributor

@a-maumau Thanks for the update. LGTM !

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) June 6, 2024 00:38
@SakodaShintaro SakodaShintaro merged commit bc8c08b into autowarefoundation:main Jun 6, 2024
24 of 25 checks passed
danielsanchezaran pushed a commit that referenced this pull request Jun 6, 2024
… to both (#7198)

change log output from screen to both

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jun 6, 2024
… to both (autowarefoundation#7198)

change log output from screen to both

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
… to both (autowarefoundation#7198)

change log output from screen to both

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
… to both (#7198)

change log output from screen to both

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: SakodaShintaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants