Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): object position update by size change #7170

Merge branch 'main' into feat/mot_obj_position_update_by_size_change

aa7a2df
Select commit
Loading
Failed to load commit list.
Merged

feat(multi_object_tracker): object position update by size change #7170

Merge branch 'main' into feat/mot_obj_position_update_by_size_change
aa7a2df
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 12, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: OK

  • Improving Code Health: 2 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

  • autoware.universe/perception/multi_object_tracker/src/tracker/model/normal_vehicle_tracker.cpp is usually changed with: autoware.universe/perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp
  • autoware.universe/perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp is usually changed with: autoware.universe/perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp

Details

✅ Improving Code Health:

  • Large Method normal_vehicle_tracker.cpp: NormalVehicleTracker::NormalVehicleTracker
  • Large Method big_vehicle_tracker.cpp: BigVehicleTracker::BigVehicleTracker

Annotations

Check notice on line 178 in perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method

BigVehicleTracker::BigVehicleTracker decreases from 112 to 109 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 179 in perception/multi_object_tracker/src/tracker/model/normal_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method

NormalVehicleTracker::NormalVehicleTracker decreases from 113 to 110 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.