-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: componentize-system_error_monitor #7009
Conversation
Signed-off-by: TetsuKawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TetsuKawa Please remove src/system_error_monitor_node.cpp
and use the following codes in src/system_error_monitor_core.cpp
.
#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(AutowareErrorMonitor)
Signed-off-by: TetsuKawa <[email protected]>
Fixed in 0e5c2df. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TetsuKawa Please address this error.
https://results.pre-commit.ci/run/github/429651616/1715699925.rSJoS8KMRCytP8t8gc8KJA
Signed-off-by: TetsuKawa <[email protected]>
@ito-san @esteve
and
were fixed in 0e5c2df. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: componentize-system_error_monitor Signed-off-by: TetsuKawa <[email protected]> * modify: componentize-system_error_monitor Signed-off-by: TetsuKawa <[email protected]> * feat: add explicit Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]> Signed-off-by: vividf <[email protected]>
* feat: componentize-system_error_monitor Signed-off-by: TetsuKawa <[email protected]> * modify: componentize-system_error_monitor Signed-off-by: TetsuKawa <[email protected]> * feat: add explicit Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]>
Description
This PR allows this node to be built as a rclcpp component.
System_error_monitor node can be executed from a customized rclcpp component.
Tests performed
Confirmed that this node was executed from a customized rclcpp component ( which included glog ).
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.