Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: componentize-system_error_monitor #7009

Merged
merged 6 commits into from
May 15, 2024

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented May 14, 2024

Description

This PR allows this node to be built as a rclcpp component.
System_error_monitor node can be executed from a customized rclcpp component.

Tests performed

Confirmed that this node was executed from a customized rclcpp component ( which included glog ).

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TetsuKawa TetsuKawa added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 14, 2024
@TetsuKawa TetsuKawa requested a review from isamu-takagi May 14, 2024 08:07
@TetsuKawa TetsuKawa self-assigned this May 14, 2024
@TetsuKawa TetsuKawa requested a review from ito-san as a code owner May 14, 2024 08:07
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TetsuKawa Please remove src/system_error_monitor_node.cpp and use the following codes in src/system_error_monitor_core.cpp.

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(AutowareErrorMonitor)

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label May 14, 2024
esteve
esteve previously requested changes May 14, 2024
system/system_error_monitor/CMakeLists.txt Outdated Show resolved Hide resolved
system/system_error_monitor/CMakeLists.txt Outdated Show resolved Hide resolved
@ito-san ito-san requested review from esteve and ito-san May 14, 2024 23:54
@ito-san
Copy link
Contributor

ito-san commented May 14, 2024

@TetsuKawa Please remove src/system_error_monitor_node.cpp and use the following codes in src/system_error_monitor_core.cpp.

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(AutowareErrorMonitor)

Fixed in 0e5c2df.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ito-san ito-san self-requested a review May 15, 2024 00:01
@TetsuKawa
Copy link
Contributor Author

@ito-san @esteve
So sorry for the late reply.
Thanks for your comment.

@TetsuKawa Please remove src/system_error_monitor_node.cpp and use the following codes in src/system_error_monitor_core.cpp.

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(AutowareErrorMonitor)

and

You can use ament_auto_add_library(${PROJECT_NAME}component SHARED here so that when we prefix packages with autoware, this code won't need to be updated.

were fixed in 0e5c2df.

Reference:https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#exporting-a-composable-node-component-executables

@TetsuKawa TetsuKawa enabled auto-merge (squash) May 15, 2024 05:25
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TetsuKawa TetsuKawa disabled auto-merge May 15, 2024 07:44
@TetsuKawa TetsuKawa merged commit d7c2288 into main May 15, 2024
22 of 23 checks passed
@TetsuKawa TetsuKawa deleted the feat/componentize-system-error-monitor branch May 15, 2024 09:13
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
* feat: componentize-system_error_monitor

Signed-off-by: TetsuKawa <[email protected]>

* modify: componentize-system_error_monitor

Signed-off-by: TetsuKawa <[email protected]>

* feat: add explicit

Signed-off-by: TetsuKawa <[email protected]>

---------

Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: vividf <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat: componentize-system_error_monitor

Signed-off-by: TetsuKawa <[email protected]>

* modify: componentize-system_error_monitor

Signed-off-by: TetsuKawa <[email protected]>

* feat: add explicit

Signed-off-by: TetsuKawa <[email protected]>

---------

Signed-off-by: TetsuKawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants