Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration #7000

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented May 14, 2024

Description

This fixes build-and-test-differential / clang-tidy-differential errors in #6987:

/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/debug.cpp:36:29: error: using decl 'createDefaultMarker' is unused [misc-unused-using-decls,-warnings-as-errors]
using tier4_autoware_utils::createDefaultMarker;
                            ^
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/debug.cpp:36:29: note: remove the using
using tier4_autoware_utils::createDefaultMarker;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~

/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:60:16: error: using decl 'ArcCoordinates' is unused [misc-unused-using-decls,-warnings-as-errors]
using lanelet::ArcCoordinates;
               ^
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:60:16: note: remove the using
using lanelet::ArcCoordinates;
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:64:16: error: using decl 'ConstLineString2d' is unused [misc-unused-using-decls,-warnings-as-errors]
using lanelet::ConstLineString2d;
               ^
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:64:16: note: remove the using
using lanelet::ConstLineString2d;
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:66:26: error: using decl 'fromArcCoordinates' is unused [misc-unused-using-decls,-warnings-as-errors]
using lanelet::geometry::fromArcCoordinates;
                         ^
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:66:26: note: remove the using
using lanelet::geometry::fromArcCoordinates;
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:67:26: error: using decl 'toArcCoordinates' is unused [misc-unused-using-decls,-warnings-as-errors]
using lanelet::geometry::toArcCoordinates;
                         ^
/__w/autoware.universe/autoware.universe/planning/behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:67:26: note: remove the using
using lanelet::geometry::toArcCoordinates;
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~

Tests performed

No

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 14, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 14, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk enabled auto-merge (squash) May 14, 2024 04:46
@shmpwk shmpwk merged commit 0e6f175 into autowarefoundation:main May 14, 2024
31 of 33 checks passed
@veqcc veqcc deleted the refactor/remove_unnecessary_declaration branch May 14, 2024 05:12
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
… declaration (autowarefoundation#7000)

* refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration

Signed-off-by: Ryuta Kambe <[email protected]>

* remove unnecessary declaration

Signed-off-by: Ryuta Kambe <[email protected]>

* unify lanelet::ArcCoordinates

Signed-off-by: Ryuta Kambe <[email protected]>

* unify lanelet::geometry::fromArcCoordinates

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

* unify lanelet::ConstLineString2d

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

* fix

Signed-off-by: veqcc <[email protected]>

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: veqcc <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: vividf <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… declaration (autowarefoundation#7000)

* refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration

Signed-off-by: Ryuta Kambe <[email protected]>

* remove unnecessary declaration

Signed-off-by: Ryuta Kambe <[email protected]>

* unify lanelet::ArcCoordinates

Signed-off-by: Ryuta Kambe <[email protected]>

* unify lanelet::geometry::fromArcCoordinates

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

* unify lanelet::ConstLineString2d

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

* fix

Signed-off-by: veqcc <[email protected]>

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: veqcc <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants