-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration #7000
Merged
shmpwk
merged 8 commits into
autowarefoundation:main
from
veqcc:refactor/remove_unnecessary_declaration
May 14, 2024
Merged
refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration #7000
shmpwk
merged 8 commits into
autowarefoundation:main
from
veqcc:refactor/remove_unnecessary_declaration
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… declaration Signed-off-by: Ryuta Kambe <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 14, 2024
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: veqcc <[email protected]>
veqcc
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 14, 2024
shmpwk
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
… declaration (autowarefoundation#7000) * refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration Signed-off-by: Ryuta Kambe <[email protected]> * remove unnecessary declaration Signed-off-by: Ryuta Kambe <[email protected]> * unify lanelet::ArcCoordinates Signed-off-by: Ryuta Kambe <[email protected]> * unify lanelet::geometry::fromArcCoordinates Signed-off-by: Ryuta Kambe <[email protected]> * style(pre-commit): autofix * unify lanelet::ConstLineString2d Signed-off-by: Ryuta Kambe <[email protected]> * style(pre-commit): autofix * fix Signed-off-by: veqcc <[email protected]> --------- Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: veqcc <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: vividf <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
… declaration (autowarefoundation#7000) * refactor(behavior_velocity_occlusion_spot_module): remove unnecessary declaration Signed-off-by: Ryuta Kambe <[email protected]> * remove unnecessary declaration Signed-off-by: Ryuta Kambe <[email protected]> * unify lanelet::ArcCoordinates Signed-off-by: Ryuta Kambe <[email protected]> * unify lanelet::geometry::fromArcCoordinates Signed-off-by: Ryuta Kambe <[email protected]> * style(pre-commit): autofix * unify lanelet::ConstLineString2d Signed-off-by: Ryuta Kambe <[email protected]> * style(pre-commit): autofix * fix Signed-off-by: veqcc <[email protected]> --------- Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: veqcc <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes
build-and-test-differential / clang-tidy-differential
errors in #6987:Tests performed
No
Effects on system behavior
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.