feat(mrm_emergency_stop_operator): add support for real time param reconfigure for mrm_emergency_stop #6994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <[email protected]>
github-actions
bot
added
the
component:system
danielsanchezaran
added
the
run:build-and-test-differential
danielsanchezaran
merged commit 2f2438e
into
autowarefoundation:main
33 of 35 checks passed
danielsanchezaran
deleted the
feat/param-update-support-mrm-emergency-stop
branch
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…configure for mrm_emergency_stop (autowarefoundation#6994) add support for real time param reconfigure for mrm_emergency_stop Signed-off-by: Daniel Sanchez <[email protected]> Signed-off-by: vividf <[email protected]>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 30, 2024
…configure for mrm_emergency_stop (autowarefoundation#6994) add support for real time param reconfigure for mrm_emergency_stop Signed-off-by: Daniel Sanchez <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…configure for mrm_emergency_stop (autowarefoundation#6994) add support for real time param reconfigure for mrm_emergency_stop Signed-off-by: Daniel Sanchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for updating mrm emergency stop with rqt_reconfigure. Also added the vector include requested by pre-commit.
Tests performed
PSim
Using the AEB module to test the changes, I lowered the min jerk and acceleration and the ego cannot stop reasonably fast (as expected), see video:
cap-.2024-05-13-17-26-16.mp4
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.