refactor(behavior_velocity_occlusion_spot_module): reduce cppcheck warning #6987
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 5 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method occlusion_spot_utils.cpp: calcSlowDownPointsForPossibleCollision
✅ Improving Code Health:
- Overall Code Complexity grid_utils.cpp
- Complex Method grid_utils.cpp: toQuantizedImage
- Complex Method grid_utils.cpp: isCollisionFree
- Bumpy Road Ahead grid_utils.cpp: isCollisionFree
- Deep, Nested Complexity grid_utils.cpp: isCollisionFree
Annotations
Check notice on line 324 in planning/behavior_velocity_occlusion_spot_module/src/grid_utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
toQuantizedImage is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 86 in planning/behavior_velocity_occlusion_spot_module/src/grid_utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
isCollisionFree is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 86 in planning/behavior_velocity_occlusion_spot_module/src/grid_utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
isCollisionFree is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/behavior_velocity_occlusion_spot_module/src/grid_utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.36 to 4.08, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 86 in planning/behavior_velocity_occlusion_spot_module/src/grid_utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Deep, Nested Complexity
isCollisionFree is no longer above the threshold for nested complexity depth
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
calcSlowDownPointsForPossibleCollision increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.05 to 4.10, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.