fix(route_handler): fix std::accumlation related bug

[veqcc]

Description

This is a fix based on clang-tidy warning

folding type 'double' into type 'int' might result in loss of precision	1

The accumulation is conducted as int, not as double, in the previous implementation.

Tests performed

No

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[soblin]

Is this all the true positive warnings from clang-tidy? I'd appreciate if you get rid of all the warning in a single PR. Thanks!

[veqcc]

@soblin
Thenk you for your quick review!

Is this all the true positive warnings from clang-tidy?

No. There are tremendous (true psitive) warnings from clang-tidy 🥹
I cannot fix all of them in one PR.

As for std::accumlation related warnings, there is acutualy one more same bug in system module.
Do you think this PR should include system module bugfix?

[soblin]

OK, then can you purge as many errors only in route_handler as possible? If this is all, then I will merge this ASAP

[veqcc]

@soblin
Other warnings in route_hander are as follows.
These would not cause immediate bugs. They are rather improvements.
I will leave it up to you whether to accept them or not (and if you accept, I will include these modifications to this PR)

• Local variable 'relation' shadows outer variable [shadowVariable]
  

  autoware.universe/planning/route_handler/src/route_handler.cpp

  Line 1930 in c24ad46

  const auto & relation = routing_graph_ptr_->routingRelation(prev_llt, llt);

• Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
  

  autoware.universe/planning/route_handler/src/route_handler.cpp

  Line 55 in c24ad46

  for (const auto & p : primitives) {

  
  

  autoware.universe/planning/route_handler/src/route_handler.cpp

  Line 66 in c24ad46

  for (const auto & i : vectors) {

  
  

  autoware.universe/planning/route_handler/src/route_handler.cpp

  Line 487 in c24ad46

  for (const auto & llt : route_lanelets_) {

  
  ... 6 more same recommendations in route_handler

• Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
  

  autoware.universe/planning/route_handler/src/route_handler.cpp

  Line 1037 in c24ad46

  for (const auto & right_lanelet : right_lanelets)

  
  

  autoware.universe/planning/route_handler/src/route_handler.cpp

  Line 1114 in c24ad46

  for (const auto & left_lanelet : left_lanelets)

[soblin]

It looks like [useStlAlgorithm] should be disabled for checking.