Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart_mpc_trajectory_follower): add smart_mpc_trajectory_follower #6805

Merged

Conversation

masayukiaino
Copy link
Contributor

@masayukiaino masayukiaino commented Apr 13, 2024

Description

This PR contains the initial implementation of the smart_mpc_trajectory_follower package, a control algorithm that combines model predictive control and machine learning.
This package replaces trajectory_follower_node package and provides adaptive vehicle control.

Tests performed

Tested on a real vehicle, autoware simulator and the python simulator included in the package.

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Apr 13, 2024
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masayukiaino some suggestions on readme

control/smart_mpc_trajectory_follower/README.md Outdated Show resolved Hide resolved
control/smart_mpc_trajectory_follower/README.md Outdated Show resolved Hide resolved
control/smart_mpc_trajectory_follower/README.md Outdated Show resolved Hide resolved
control/smart_mpc_trajectory_follower/README.md Outdated Show resolved Hide resolved
@TakaHoribe TakaHoribe self-requested a review April 24, 2024 03:11
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 1, 2024
@TakaHoribe TakaHoribe self-requested a review May 8, 2024 06:49
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 enabled auto-merge (squash) May 14, 2024 08:13
@kosuke55 kosuke55 merged commit f30c035 into autowarefoundation:main May 14, 2024
20 of 22 checks passed
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
autowarefoundation#6805)

* feat(smart_mpc_trajectory_follower): add smart_mpc_trajectory_follower

* style(pre-commit): autofix

* modified control.launch.py

* update README.md

* Minor changes

* style(pre-commit): autofix

* bug fixed

* update README and add a comment to mpc_param.yaml

* minor changes

* add copyright

* mpc_param.yaml changed

* add note to README

* update according to spell check

* update python_simulator according to spell check

* update scripts according to spell check

* update according to spell-check-partial

* fixed ignored words in spell check

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
Signed-off-by: vividf <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#6805)

* feat(smart_mpc_trajectory_follower): add smart_mpc_trajectory_follower

* style(pre-commit): autofix

* modified control.launch.py

* update README.md

* Minor changes

* style(pre-commit): autofix

* bug fixed

* update README and add a comment to mpc_param.yaml

* minor changes

* add copyright

* mpc_param.yaml changed

* add note to README

* update according to spell check

* update python_simulator according to spell check

* update scripts according to spell check

* update according to spell-check-partial

* fixed ignored words in spell check

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants