Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occupancy_grid_map_outlier_filter): add intensity field #6797

Merged
merged 9 commits into from
May 7, 2024

fix: typo

e233082
Select commit
Loading
Failed to load commit list.
Merged

fix(occupancy_grid_map_outlier_filter): add intensity field #6797

fix: typo
e233082
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 7, 2024 in 41s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method occupancy_grid_map_outlier_filter_nodelet.cpp: OccupancyGridMapOutlierFilterComponent::onOccupancyGridMapAndPointCloud2

✅ Improving Code Health:

  • Bumpy Road Ahead occupancy_grid_map_outlier_filter_nodelet.cpp: OccupancyGridMapOutlierFilterComponent::splitPointCloudFrontBack

Annotations

Check warning on line 363 in perception/occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method 

OccupancyGridMapOutlierFilterComponent::onOccupancyGridMapAndPointCloud2 has 74 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 292 in perception/occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Bumpy Road Ahead 

OccupancyGridMapOutlierFilterComponent::splitPointCloudFrontBack is no longer above the threshold for logical blocks with deeply nested code
View more details on CodeScene Delta Analysis