-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ndt_scan_matcher): add grid_search initial pose estimation #6790
feat(ndt_scan_matcher): add grid_search initial pose estimation #6790
Conversation
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Good 👍 |
@SakodaShintaro Thanks for your work and explanations. I would like to ask a few questions about your work.
|
@meliketanrikulu First, I apologize for not being descriptive about the status of this pull request.
There is no change in the NDT usage, so the initial pose estimation time will continue to be proportional to the number of particles. With this setting, we search 3 x 3 in the x, y direction and 80 in the yaw direction, so the total is 3 * 3 * 80 = 720 particles.
In this pull request change, stddev is completely ignored and the search range is determined by the grid search settings. |
Thanks for the quick reply and explanations. In addition, stddev is useful information for incoming poses and I think it should be used but I don't know how exactly it can be integrated into this method. |
Reply
I completely agree. 👍 However, I think that the reason why initial position estimation fails is not that it cannot be optimized sufficiently, but rather that the correct pose cannot be covered with about 200 particles. So, I'm not confident that the method you're pointing out will work.
What I'm currently tryingI'm currently trying out the method in the following paper. For quick trial and error, I'm implementing it in the tier4/ndt_omp@tier4/main...tier4:ndt_omp:feat/add_initialpose_estimation If the experiments in the (We plan to use GNSS stddev to determine the search range in this method.) About GNSSAlso, the current
|
We have introduced some improvements to initial pose estimation in another pull request, so we are closing this pull request for now since it now takes a lot of time to estimate the initial pose. |
Must be merged with autowarefoundation/autoware_launch#952
Description
Context
The current
ndt_scan_matcher
performs pure random search or TPE(Tree-structured Parzen Estimator) search in initial pose estimation. However, both methods suffer from randomness, which introduces uncertainty in the initial pose when tested using thelogging_simulator
.This pull request implements grid search to reduce uncertainty.
visualize initial poses
grid_search_initial_pose_vidualize_initial_poses.webm
visualize result poses
grid_search_initial_pose_estimation.webm
Tests performed
Effects on system behavior
The time required for initial pose estimation will increase, but the randomness will decrease.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.