Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_autoware_utils): clang-tidy errors for published_time_publisher #6651

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Mar 18, 2024

Description

Fixes some clang-tidy errors on this code.

Related:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx requested a review from brkay54 March 18, 2024 12:25
@xmfcx xmfcx self-assigned this Mar 18, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Mar 18, 2024
@xmfcx xmfcx added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 18, 2024
@xmfcx xmfcx force-pushed the fix/clang-tidy-tier4_autoware_utils branch from d90b377 to 52e6515 Compare March 18, 2024 12:28
Copy link
Member

@brkay54 brkay54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🙏🏼

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.79%. Comparing base (bd568e8) to head (52e6515).

Files Patch % Lines
...r4_autoware_utils/ros/published_time_publisher.hpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6651      +/-   ##
==========================================
- Coverage   14.79%   14.79%   -0.01%     
==========================================
  Files        1925     1925              
  Lines      132643   132643              
  Branches    39491    39487       -4     
==========================================
- Hits        19627    19622       -5     
- Misses      91051    91058       +7     
+ Partials    21965    21963       -2     
Flag Coverage Δ *Carryforward flag
differential 15.91% <0.00%> (?)
total 14.79% <ø> (-0.01%) ⬇️ Carriedforward from 413514b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx merged commit 3b53061 into main Mar 18, 2024
29 of 31 checks passed
@xmfcx xmfcx deleted the fix/clang-tidy-tier4_autoware_utils branch March 18, 2024 22:32
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants