chore(ground_segmentation_launch): change max_z of cropbox filter to vehicle_height #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vehicle_height Signed-off-by: badai-nguyen <[email protected]>
github-actions
bot
added
the
component:launch
Merged
4 tasks
badai-nguyen
requested review from
miursh,
YoshiRi and
yukkysaito
as code owners
|
@badai-nguyen |
|
@badai-nguyen here is parameter dump result 🙏 |
Signed-off-by: badai-nguyen <[email protected]>
|
@yukkysaito I'm so sorry for my typo mistake 🙇 . I fixed https://github.com/autowarefoundation/autoware.universe/pull/6549/commits |
|
|
badai-nguyen
added
the
run:build-and-test-differential
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…vehicle_height (#6549) * chore(ground_segmentation_launch): change max_z of cropbox filter to vehicle_height Signed-off-by: badai-nguyen <[email protected]> * fix: typo Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…vehicle_height (autowarefoundation#6549) * chore(ground_segmentation_launch): change max_z of cropbox filter to vehicle_height Signed-off-by: badai-nguyen <[email protected]> * fix: typo Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: kaigohirao <[email protected]>
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 22, 2024
…vehicle_height (autowarefoundation#6549) * chore(ground_segmentation_launch): change max_z of cropbox filter to vehicle_height Signed-off-by: badai-nguyen <[email protected]> * fix: typo Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 23, 2024
…vehicle_height (autowarefoundation#6549) * chore(ground_segmentation_launch): change max_z of cropbox filter to vehicle_height Signed-off-by: badai-nguyen <[email protected]> * fix: typo Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…vehicle_height (autowarefoundation#6549) * chore(ground_segmentation_launch): change max_z of cropbox filter to vehicle_height Signed-off-by: badai-nguyen <[email protected]> * fix: typo Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vehicle_heightformax_zparameter of `/perception/obstacle_segmentation/xx_crop_box_filter' nodesRelated_link
TIER IV INTERNAL LINK
Tests performed
logging_simulatorthat the correctmax_zandmin_zwere parsed to `obstacle_segmentation/crop_box_filter' node as desired.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.