fix(bpp): overwrite turn signal by latter module #6543
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, behavior path planner module outputs unnecessary turn signal while multiple modules are running simlutaneously.
Related ticket: https://tier4.atlassian.net/browse/RT1-5329
simplescreenrecorder-2024-03-07_13.16.32.mp4
Currently, turn signal decider manages multiple turn singal infomation (e.g. lane change, avoidance, turn right/left...) based on this logic. But I think it's better to overwrite turn signal simply by latter module one in terms of the signal management among multiple modules because, in most case, the latter module's path modufication is dominant.
In this PR, I added a new function to overwrite turn signal when the ego's in the section that calculated by latter module.
------|--- turn signal section A ---------|--------------------------------------------------------
----------------------------------------|------ turn signal section B ------|----------------------
------|--- turn signal section A --|------ turn signal section B ------|----------------------
Avoidance -> LC
simplescreenrecorder-2024-03-05_14.34.26.mp4
LC -> Avoidance
simplescreenrecorder-2024-03-05_14.35.24.mp4
Tests performed
Effects on system behavior
Fix unnecessary turn signal.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.