Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpp): overwrite turn signal by latter module #6543

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 5, 2024

Description

Sometimes, behavior path planner module outputs unnecessary turn signal while multiple modules are running simlutaneously.

Related ticket: https://tier4.atlassian.net/browse/RT1-5329

Screenshot from 2024-03-07 13-52-18

simplescreenrecorder-2024-03-07_13.16.32.mp4

Currently, turn signal decider manages multiple turn singal infomation (e.g. lane change, avoidance, turn right/left...) based on this logic. But I think it's better to overwrite turn signal simply by latter module one in terms of the signal management among multiple modules because, in most case, the latter module's path modufication is dominant.

In this PR, I added a new function to overwrite turn signal when the ego's in the section that calculated by latter module.

  • former module:
    ------|--- turn signal section A ---------|--------------------------------------------------------
  • latter module:
    ----------------------------------------|------ turn signal section B ------|----------------------
  • overwrite:
    ------|--- turn signal section A --|------ turn signal section B ------|----------------------

Avoidance -> LC

simplescreenrecorder-2024-03-05_14.34.26.mp4

LC -> Avoidance

simplescreenrecorder-2024-03-05_14.35.24.mp4

Tests performed

Effects on system behavior

Fix unnecessary turn signal.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 5, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 14.75%. Comparing base (7081a61) to head (5546035).
Report is 20 commits behind head on main.

Files Patch % Lines
...or_path_planner_common/src/turn_signal_decider.cpp 0.00% 14 Missing ⚠️
...ing/behavior_path_lane_change_module/src/scene.cpp 0.00% 3 Missing ⚠️
...nning/behavior_path_avoidance_module/src/scene.cpp 0.00% 1 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 1 Missing ⚠️
...behavior_path_lane_change_module/src/interface.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6543      +/-   ##
==========================================
- Coverage   14.80%   14.75%   -0.06%     
==========================================
  Files        1917     1917              
  Lines      132086   132963     +877     
  Branches    39262    39446     +184     
==========================================
+ Hits        19553    19614      +61     
- Misses      90715    91501     +786     
- Partials    21818    21848      +30     
Flag Coverage Δ *Carryforward flag
differential 10.74% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from 7081a61

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota removed the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 1, 2024
@satoshi-ota
Copy link
Contributor Author

Close this PR. I'll create new PR if need.

@satoshi-ota satoshi-ota closed this May 1, 2024
@satoshi-ota satoshi-ota deleted the fix/turn-signal-consistency branch May 1, 2024 05:14
@satoshi-ota satoshi-ota restored the fix/turn-signal-consistency branch May 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants