Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mrm_handler): delete control_cmd publish function #6514

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Feb 29, 2024

Description

Since publishControlCmd function no longer publishes control_cmd, it was a misleading name.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@veqcc veqcc requested review from mkuri and TetsuKawa February 29, 2024 05:17
@veqcc veqcc self-assigned this Feb 29, 2024
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Feb 29, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (888fec6) to head (5cfa39b).

Files Patch % Lines
...m/mrm_handler/src/mrm_handler/mrm_handler_core.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6514      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      132012   132017       +5     
  Branches    39228    39228              
==========================================
  Hits        19523    19523              
- Misses      90699    90704       +5     
  Partials    21790    21790              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 888fec6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit d3886e4 into autowarefoundation:main Mar 6, 2024
22 of 24 checks passed
@veqcc veqcc deleted the refactor_mrm_handler branch March 6, 2024 07:12
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* refactor(mrm_handler): delete control_cmd publish function

Signed-off-by: veqcc <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…oundation#6514)

* refactor(mrm_handler): delete control_cmd publish function

Signed-off-by: veqcc <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
mkuri pushed a commit to tier4/autoware.universe that referenced this pull request Mar 28, 2024
…oundation#6514)

* refactor(mrm_handler): delete control_cmd publish function

Signed-off-by: veqcc <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…oundation#6514)

* refactor(mrm_handler): delete control_cmd publish function

Signed-off-by: veqcc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants