fix(mrm_handler): fix bug in operation mode availability timeout #6513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: veqcc <[email protected]>
veqcc
changed the title
veqcc
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6513 +/- ##
==========================================
- Coverage 14.78% 14.78% -0.01%
==========================================
Files 1917 1917
Lines 132253 132261 +8
Branches 39297 39297
==========================================
Hits 19550 19550
- Misses 90876 90884 +8
Partials 21827 21827
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
How is the MRM behavior determined when a timeout is established? Please check the timeout behavior with Psim. |
Signed-off-by: veqcc <[email protected]>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* fix operation mode availability timeout Signed-off-by: veqcc <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…owarefoundation#6513) * fix operation mode availability timeout Signed-off-by: veqcc <[email protected]> Signed-off-by: kaigohirao <[email protected]>
mkuri
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 28, 2024
…owarefoundation#6513) * fix operation mode availability timeout Signed-off-by: veqcc <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…owarefoundation#6513) * fix operation mode availability timeout Signed-off-by: veqcc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed how to handle
operation_mode_availabilitytimeout in mrm_handler.Previously, when
operation_mode_availabilitytimeout is detected,onTimercallback just changes themrm_stateand publish some commands. However, this is not enough for an MRM operation since no MRM behavior is requested.This Pull Request solved the problem.
This is almost the same change as #6399 .
Tests performed
Comfirmed MRM changes from (NORMAL, NONE) to (OPERATING, EMERGENCY_STOP) when
operation_mode_availabilitytimed outs.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.