refactor(ndt_scan_matcher): fixed ndt_scan_matcher.launch.xml

[SakodaShintaro]

Description

The topic name settings in ndt_scan_matcher.launch.xml have been changed.

Detail

It is recommended to use abstract topic names for topics described in launch within a package. ekf_localizer.launch.xml is a good example. Following this, I made the same changes to ndt_scan_matcher.

The specific topic name is deleted in the launch file in the ndt_scan_matcher package. Instead, set the name used by autoware in launch/tier4_localization_launch/launch/pose_twist_estimator/ndt_scan_matcher.launch.xml.

As a minor change, I also aligned the order in which topic names are written in these files.

Also, input_map_points_topic has been removed as it is no longer used. Originally it should have been removed at #5873.

Tests performed

It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

• Before : 0.047 [m]
• After : 0.046 [m]

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[KYabuuchi]

Thanks for refactoring 🙆

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a6c16b) 15.22% compared to head (32d2679) 15.23%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6041   +/-   ##
=======================================
  Coverage   15.22%   15.23%           
=======================================
  Files        1767     1767           
  Lines      121695   121694    -1     
  Branches    37020    37020           
=======================================
  Hits        18534    18534           
+ Misses      82349    82348    -1     
  Partials    20812    20812           

Flag	Coverage Δ		*Carryforward flag
differential	2.93% <ø> (?)
total	15.23% <ø> (+<0.01%)	⬆️	Carriedforward from 2a6c16b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.