fix(static_drivable_area_expansion): fix bound extraction logic #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
satoshi-ota
requested review from
danielsanchezaran,
rej55,
kosuke55,
soblin,
maxime-clem,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/polygon-bound-extract
branch
from
5aa7002 to
a7dcce6
Compare
satoshi-ota
added
the
run:build-and-test-differential
rej55
approved these changes
Jan 10, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6006 +/- ##
==========================================
- Coverage 15.23% 15.18% -0.06%
==========================================
Files 1751 1756 +5
Lines 120918 122253 +1335
Branches 36770 37524 +754
==========================================
+ Hits 18423 18561 +138
- Misses 81824 82692 +868
- Partials 20671 21000 +329
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 11, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
4 tasks
zulfaqar-azmi-t4
pushed a commit
to zulfaqar-azmi-t4/autoware.universe
that referenced
this pull request
Jan 11, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 8, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 1, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 8, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…warefoundation#6006) * fix(static_drivable_area_expansion): fix bound extraction logic Signed-off-by: satoshi-ota <[email protected]> * refactor(static_drivable_area_expansion): define as anon func Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix drivable bound extracsion logic in 0fb37b1. Before this PR, sometimes the intersection area bound was broken like following fig.
Tests performed
Psim (map: odaiba_stable/222-20231225030104904261)
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.